Re: [Qemu-block] [PATCH v2 2/5] crypto/block: refactor qcrypto_block_*crypt_helper functions

2018-12-07 Thread Alberto Garcia
On Wed 05 Dec 2018 03:46:57 PM CET, Vladimir Sementsov-Ogievskiy wrote: > qcrypto_block_encrypt_helper and qcrypto_block_decrypt_helper are > almost identical, let's reduce code duplication and simplify further > improvements. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > +static int do_qcry

Re: [Qemu-block] [PATCH v2 2/5] crypto/block: refactor qcrypto_block_*crypt_helper functions

2018-12-07 Thread Daniel P . Berrangé
On Thu, Dec 06, 2018 at 05:36:29PM +, Vladimir Sementsov-Ogievskiy wrote: > 06.12.2018 13:36, Daniel P. Berrangé wrote: > > On Wed, Dec 05, 2018 at 05:46:57PM +0300, Vladimir Sementsov-Ogievskiy > > wrote: > >> qcrypto_block_encrypt_helper and qcrypto_block_decrypt_helper are > >> almost ident

Re: [Qemu-block] [PATCH v2 2/5] crypto/block: refactor qcrypto_block_*crypt_helper functions

2018-12-06 Thread Vladimir Sementsov-Ogievskiy
06.12.2018 13:36, Daniel P. Berrangé wrote: > On Wed, Dec 05, 2018 at 05:46:57PM +0300, Vladimir Sementsov-Ogievskiy wrote: >> qcrypto_block_encrypt_helper and qcrypto_block_decrypt_helper are >> almost identical, let's reduce code duplication and simplify further >> improvements. >> >> Signed-off-

Re: [Qemu-block] [PATCH v2 2/5] crypto/block: refactor qcrypto_block_*crypt_helper functions

2018-12-06 Thread Daniel P . Berrangé
On Wed, Dec 05, 2018 at 05:46:57PM +0300, Vladimir Sementsov-Ogievskiy wrote: > qcrypto_block_encrypt_helper and qcrypto_block_decrypt_helper are > almost identical, let's reduce code duplication and simplify further > improvements. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > crypto/

[Qemu-block] [PATCH v2 2/5] crypto/block: refactor qcrypto_block_*crypt_helper functions

2018-12-05 Thread Vladimir Sementsov-Ogievskiy
qcrypto_block_encrypt_helper and qcrypto_block_decrypt_helper are almost identical, let's reduce code duplication and simplify further improvements. Signed-off-by: Vladimir Sementsov-Ogievskiy --- crypto/block.c | 81 +++--- 1 file changed, 31 insertio