Re: [Qemu-block] [PATCH v2 3/3] xen-disk: use an IOThread per instance

2017-07-10 Thread Paul Durrant
> -Original Message- [snip] > > > > +object_unparent(OBJECT(blkdev->iothread)); > > > > > > Shouldn't this be object_unref? > > > > > > > I don't think so. I think this is required to undo what was done by calling > object_property_add_child() on the root object. > > Right, so if objec

Re: [Qemu-block] [PATCH v2 3/3] xen-disk: use an IOThread per instance

2017-07-07 Thread Stefano Stabellini
On Fri, 7 Jul 2017, Paul Durrant wrote: > > -Original Message- > > From: Stefano Stabellini [mailto:sstabell...@kernel.org] > > Sent: 22 June 2017 23:15 > > To: Paul Durrant > > Cc: xen-de...@lists.xenproject.org; qemu-de...@nongnu.org; qemu- > > bl...@nongnu.org; Stefano Stabellini ; Anth

Re: [Qemu-block] [PATCH v2 3/3] xen-disk: use an IOThread per instance

2017-07-07 Thread Paul Durrant
> -Original Message- > From: Stefano Stabellini [mailto:sstabell...@kernel.org] > Sent: 22 June 2017 23:15 > To: Paul Durrant > Cc: xen-de...@lists.xenproject.org; qemu-de...@nongnu.org; qemu- > bl...@nongnu.org; Stefano Stabellini ; Anthony > Perard ; Kevin Wolf ; > Max Reitz ; afaer...@s

Re: [Qemu-block] [PATCH v2 3/3] xen-disk: use an IOThread per instance

2017-06-22 Thread Stefano Stabellini
CC'ing Andreas Färber. Could you please give a quick look below at the way the iothread object is instantiate and destroyed? I am no object model expert and would appreaciate a second opinion. On Wed, 21 Jun 2017, Paul Durrant wrote: > This patch allocates an IOThread object for each xen_disk ins

[Qemu-block] [PATCH v2 3/3] xen-disk: use an IOThread per instance

2017-06-21 Thread Paul Durrant
This patch allocates an IOThread object for each xen_disk instance and sets the AIO context appropriately on connect. This allows processing of I/O to proceed in parallel. The patch also adds tracepoints into xen_disk to make it possible to follow the state transtions of an instance in the log. S