[Qemu-block] [PATCH v2 3/6] qapi: add nbd-server-remove

2017-12-07 Thread Vladimir Sementsov-Ogievskiy
Add command for export removing. It is needed for cases when we don't want to keep export after the operation on it was completed. The other example is temporary node, created with blockdev-add. If we want to delete it we should firstly remove corresponding NBD export. Signed-off-by: Vladimir Seme

[Qemu-block] [PATCH v2 3/6] qapi: add nbd-server-remove

2018-01-18 Thread Vladimir Sementsov-Ogievskiy
Add command for export removing. It is needed for cases when we don't want to keep export after the operation on it was completed. The other example is temporary node, created with blockdev-add. If we want to delete it we should firstly remove corresponding NBD export. Signed-off-by: Vladimir Seme

Re: [Qemu-block] [PATCH v2 3/6] qapi: add nbd-server-remove

2018-01-09 Thread Eric Blake
On 12/07/2017 09:50 AM, Vladimir Sementsov-Ogievskiy wrote: > Add command for export removing. It is needed for cases when we > don't want to keep export after the operation on it was completed. > The other example is temporary node, created with blockdev-add. > If we want to delete it we should fi

Re: [Qemu-block] [PATCH v2 3/6] qapi: add nbd-server-remove

2018-01-12 Thread Vladimir Sementsov-Ogievskiy
09.01.2018 22:52, Eric Blake wrote: On 12/07/2017 09:50 AM, Vladimir Sementsov-Ogievskiy wrote: Add command for export removing. It is needed for cases when we don't want to keep export after the operation on it was completed. The other example is temporary node, created with blockdev-add. If we

Re: [Qemu-block] [PATCH v2 3/6] qapi: add nbd-server-remove

2018-01-15 Thread Eric Blake
On 01/12/2018 03:47 AM, Vladimir Sementsov-Ogievskiy wrote: > 09.01.2018 22:52, Eric Blake wrote: >> On 12/07/2017 09:50 AM, Vladimir Sementsov-Ogievskiy wrote: >>> Add command for export removing. It is needed for cases when we >>> don't want to keep export after the operation on it was completed.

Re: [Qemu-block] [PATCH v2 3/6] qapi: add nbd-server-remove

2018-01-15 Thread Vladimir Sementsov-Ogievskiy
15.01.2018 18:09, Eric Blake wrote: On 01/12/2018 03:47 AM, Vladimir Sementsov-Ogievskiy wrote: 09.01.2018 22:52, Eric Blake wrote: On 12/07/2017 09:50 AM, Vladimir Sementsov-Ogievskiy wrote: Add command for export removing. It is needed for cases when we don't want to keep export after the op

Re: [Qemu-block] [PATCH v2 3/6] qapi: add nbd-server-remove

2018-01-17 Thread Vladimir Sementsov-Ogievskiy
15.01.2018 20:47, Vladimir Sementsov-Ogievskiy wrote: 15.01.2018 18:09, Eric Blake wrote: On 01/12/2018 03:47 AM, Vladimir Sementsov-Ogievskiy wrote: 09.01.2018 22:52, Eric Blake wrote: On 12/07/2017 09:50 AM, Vladimir Sementsov-Ogievskiy wrote: Add command for export removing. It is needed f

Re: [Qemu-block] [PATCH v2 3/6] qapi: add nbd-server-remove

2018-01-17 Thread Eric Blake
On 01/17/2018 07:36 AM, Vladimir Sementsov-Ogievskiy wrote: looks interesting. what about the following naming? @mode: possible values:    hide - just hide server from new clients, maintain existing connections,    remove after all

Re: [Qemu-block] [PATCH v2 3/6] qapi: add nbd-server-remove

2018-01-17 Thread Vladimir Sementsov-Ogievskiy
17.01.2018 18:23, Eric Blake wrote: On 01/17/2018 07:36 AM, Vladimir Sementsov-Ogievskiy wrote: looks interesting. what about the following naming? @mode: possible values:    hide - just hide server from new clients, maintain existing connections,    remov

Re: [Qemu-block] [PATCH v2 3/6] qapi: add nbd-server-remove

2018-01-17 Thread Eric Blake
On 01/17/2018 09:51 AM, Vladimir Sementsov-Ogievskiy wrote: >>> I have a script (for managing libvirt guest, but it can be adopted for >>> qemu or even used for qemu monitor), which allows >>> me run qmp commands on vms as easy as: >>> >>> |qmp VMNAME query-block-jobs or qmp VMNAME nbd-server-remo

Re: [Qemu-block] [PATCH v2 3/6] qapi: add nbd-server-remove

2018-01-17 Thread Vladimir Sementsov-Ogievskiy
17.01.2018 19:03, Eric Blake wrote: On 01/17/2018 09:51 AM, Vladimir Sementsov-Ogievskiy wrote: I have a script (for managing libvirt guest, but it can be adopted for qemu or even used for qemu monitor), which allows me run qmp commands on vms as easy as: |qmp VMNAME query-block-jobs or qmp VM

Re: [Qemu-block] [PATCH v2 3/6] qapi: add nbd-server-remove

2018-01-18 Thread Eric Blake
On 01/18/2018 12:11 PM, Vladimir Sementsov-Ogievskiy wrote: > Add command for export removing. It is needed for cases when we s/export removing/removing an export/ > don't want to keep export after the operation on it was completed. > The other example is temporary node, created with blockdev-add

Re: [Qemu-block] [PATCH v2 3/6] qapi: add nbd-server-remove

2018-01-26 Thread Dr. David Alan Gilbert
* Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote: > 17.01.2018 19:03, Eric Blake wrote: > > On 01/17/2018 09:51 AM, Vladimir Sementsov-Ogievskiy wrote: > > > > > > > I have a script (for managing libvirt guest, but it can be adopted for > > > > > qemu or even used for qemu monitor),

Re: [Qemu-block] [PATCH v2 3/6] qapi: add nbd-server-remove

2018-02-06 Thread Vladimir Sementsov-Ogievskiy
26.01.2018 18:05, Dr. David Alan Gilbert wrote: * Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote: 17.01.2018 19:03, Eric Blake wrote: On 01/17/2018 09:51 AM, Vladimir Sementsov-Ogievskiy wrote: I have a script (for managing libvirt guest, but it can be adopted for qemu or even

Re: [Qemu-block] [PATCH v2 3/6] qapi: add nbd-server-remove

2018-02-06 Thread Eric Blake
On 02/06/2018 09:29 AM, Vladimir Sementsov-Ogievskiy wrote: most of commands, ported to hmp are done in same style: they just call corresponding qmp command. Isn't it better to provide common interface for calling qmp commands through HMP monitor, to never create hmp versions of new commands?

Re: [Qemu-block] [PATCH v2 3/6] qapi: add nbd-server-remove

2018-02-06 Thread Vladimir Sementsov-Ogievskiy
06.02.2018 19:06, Eric Blake wrote: On 02/06/2018 09:29 AM, Vladimir Sementsov-Ogievskiy wrote: most of commands, ported to hmp are done in same style: they just call corresponding qmp command. Isn't it better to provide common interface for calling qmp commands through HMP monitor, to never

Re: [Qemu-block] [PATCH v2 3/6] qapi: add nbd-server-remove

2018-02-06 Thread Dr. David Alan Gilbert
* Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote: > 26.01.2018 18:05, Dr. David Alan Gilbert wrote: > > * Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote: > > > 17.01.2018 19:03, Eric Blake wrote: > > > > On 01/17/2018 09:51 AM, Vladimir Sementsov-Ogievskiy wrote: > > >