Re: [Qemu-block] [PATCH v2 4/4] block/dirty-bitmaps: implement inconsistent bit

2019-02-28 Thread Vladimir Sementsov-Ogievskiy
28.02.2019 2:48, John Snow wrote: > > > On 2/25/19 11:21 AM, Vladimir Sementsov-Ogievskiy wrote: >> 23.02.2019 3:22, John Snow wrote: >>> Set the inconsistent bit on load instead of rejecting such bitmaps. >>> There is no way to un-set it; the only option is to delete it. >>> >>> Obvervations: >>

Re: [Qemu-block] [PATCH v2 4/4] block/dirty-bitmaps: implement inconsistent bit

2019-02-27 Thread John Snow
On 2/25/19 11:21 AM, Vladimir Sementsov-Ogievskiy wrote: > 23.02.2019 3:22, John Snow wrote: >> Set the inconsistent bit on load instead of rejecting such bitmaps. >> There is no way to un-set it; the only option is to delete it. >> >> Obvervations: >> - bitmap loading does not need to update th

Re: [Qemu-block] [PATCH v2 4/4] block/dirty-bitmaps: implement inconsistent bit

2019-02-25 Thread Vladimir Sementsov-Ogievskiy
23.02.2019 3:22, John Snow wrote: > Set the inconsistent bit on load instead of rejecting such bitmaps. > There is no way to un-set it; the only option is to delete it. > > Obvervations: > - bitmap loading does not need to update the header for in_use bitmaps. > - inconsistent bitmaps don't need t

[Qemu-block] [PATCH v2 4/4] block/dirty-bitmaps: implement inconsistent bit

2019-02-22 Thread John Snow
Set the inconsistent bit on load instead of rejecting such bitmaps. There is no way to un-set it; the only option is to delete it. Obvervations: - bitmap loading does not need to update the header for in_use bitmaps. - inconsistent bitmaps don't need to have their data loaded; they're glorified