[Qemu-block] [PATCH v3] block/gluster: Handle changed glfs_ftruncate signature

2018-07-27 Thread Niels de Vos
From: Prasanna Kumar Kalever New versions of Glusters libgfapi.so have an updated glfs_ftruncate() function that returns additional 'struct stat' structures to enable advanced caching of attributes. This is useful for file servers, not so much for QEMU. Nevertheless, the API has changed and needs

Re: [Qemu-block] [PATCH v3] block/gluster: Handle changed glfs_ftruncate signature

2018-07-27 Thread Eric Blake
On 07/27/2018 03:19 AM, Niels de Vos wrote: From: Prasanna Kumar Kalever New versions of Glusters libgfapi.so have an updated glfs_ftruncate() function that returns additional 'struct stat' structures to enable advanced caching of attributes. This is useful for file servers, not so much for QEM

Re: [Qemu-block] [PATCH v3] block/gluster: Handle changed glfs_ftruncate signature

2018-07-27 Thread Jeff Cody
On Fri, Jul 27, 2018 at 08:24:05AM -0500, Eric Blake wrote: > On 07/27/2018 03:19 AM, Niels de Vos wrote: > >From: Prasanna Kumar Kalever > > > >New versions of Glusters libgfapi.so have an updated glfs_ftruncate() > >function that returns additional 'struct stat' structures to enable > >advanced

Re: [Qemu-block] [PATCH v3] block/gluster: Handle changed glfs_ftruncate signature

2018-07-28 Thread Niels de Vos
On Sat, Jul 28, 2018 at 12:18:39AM -0400, Jeff Cody wrote: > On Fri, Jul 27, 2018 at 08:24:05AM -0500, Eric Blake wrote: > > On 07/27/2018 03:19 AM, Niels de Vos wrote: > > >From: Prasanna Kumar Kalever > > > > > >New versions of Glusters libgfapi.so have an updated glfs_ftruncate() > > >function

Re: [Qemu-block] [PATCH v3] block/gluster: Handle changed glfs_ftruncate signature

2018-07-30 Thread Eric Blake
On 07/28/2018 02:50 AM, Niels de Vos wrote: Part of me wishes that libgfapi had just created a new function 'glfs_ftruncate2', so that existing users don't need to handle the api change. But I guess in the grand scheme, not a huge deal either way. Gluster uses versioned symbols, so older bina

Re: [Qemu-block] [PATCH v3] block/gluster: Handle changed glfs_ftruncate signature

2018-07-30 Thread Jeff Cody
On Mon, Jul 30, 2018 at 10:07:27AM -0500, Eric Blake wrote: > On 07/28/2018 02:50 AM, Niels de Vos wrote: > >> > >>Part of me wishes that libgfapi had just created a new function > >>'glfs_ftruncate2', so that existing users don't need to handle the api > >>change. But I guess in the grand scheme,

Re: [Qemu-block] [PATCH v3] block/gluster: Handle changed glfs_ftruncate signature

2018-07-30 Thread Jeff Cody
On Sat, Jul 28, 2018 at 09:50:05AM +0200, Niels de Vos wrote: > On Sat, Jul 28, 2018 at 12:18:39AM -0400, Jeff Cody wrote: > > On Fri, Jul 27, 2018 at 08:24:05AM -0500, Eric Blake wrote: > > > On 07/27/2018 03:19 AM, Niels de Vos wrote: > > > >From: Prasanna Kumar Kalever > > > > > > > >New versio

Re: [Qemu-block] [PATCH v3] block/gluster: Handle changed glfs_ftruncate signature

2018-07-31 Thread Niels de Vos
On Mon, Jul 30, 2018 at 03:27:29PM -0400, Jeff Cody wrote: > On Mon, Jul 30, 2018 at 10:07:27AM -0500, Eric Blake wrote: > > On 07/28/2018 02:50 AM, Niels de Vos wrote: > > >> > > >>Part of me wishes that libgfapi had just created a new function > > >>'glfs_ftruncate2', so that existing users don't

Re: [Qemu-block] [PATCH v3] block/gluster: Handle changed glfs_ftruncate signature

2018-07-31 Thread Jeff Cody
On Tue, Jul 31, 2018 at 11:18:02AM +0200, Niels de Vos wrote: > On Mon, Jul 30, 2018 at 03:27:29PM -0400, Jeff Cody wrote: > > On Mon, Jul 30, 2018 at 10:07:27AM -0500, Eric Blake wrote: > > > On 07/28/2018 02:50 AM, Niels de Vos wrote: > > > >> > > > >>Part of me wishes that libgfapi had just crea

Re: [Qemu-block] [PATCH v3] block/gluster: Handle changed glfs_ftruncate signature

2018-08-01 Thread Niels de Vos
On Tue, Jul 31, 2018 at 03:51:22PM -0400, Jeff Cody wrote: > On Tue, Jul 31, 2018 at 11:18:02AM +0200, Niels de Vos wrote: > > On Mon, Jul 30, 2018 at 03:27:29PM -0400, Jeff Cody wrote: > > > On Mon, Jul 30, 2018 at 10:07:27AM -0500, Eric Blake wrote: > > > > On 07/28/2018 02:50 AM, Niels de Vos wr

Re: [Qemu-block] [PATCH v3] block/gluster: Handle changed glfs_ftruncate signature

2018-08-01 Thread Eric Blake
On 08/01/2018 06:47 AM, Niels de Vos wrote: If glusterfs-5 releases in October, that may line up with 3.1 or 3.2. Ok, I'll keep these kind of patches in my tree as work-in-progress and when the glusterfs-5 gets tagged for alpha/beta send it again. Even if not optimal, would you accept this as