Re: [Qemu-block] [PATCH v3] virtio-blk: trivial code optimization

2015-11-10 Thread Stefan Hajnoczi
On Tue, Nov 10, 2015 at 02:35:19PM +0800, Gonglei wrote: > On 2015/11/9 21:57, Stefan Hajnoczi wrote: > > On Mon, Nov 09, 2015 at 05:03:30PM +0800, arei.gong...@huawei.com wrote: > >> From: Gonglei > >> > >> 1. avoid possible superflous checking > >> 2. make code more

Re: [Qemu-block] [PATCH v3] virtio-blk: trivial code optimization

2015-11-09 Thread Stefan Hajnoczi
On Mon, Nov 09, 2015 at 05:03:30PM +0800, arei.gong...@huawei.com wrote: > From: Gonglei > > 1. avoid possible superflous checking > 2. make code more robustness > > Signed-off-by: Gonglei > Reviewed-by: Fam Zheng > --- > v3:

Re: [Qemu-block] [PATCH v3] virtio-blk: trivial code optimization

2015-11-09 Thread Paolo Bonzini
On 09/11/2015 10:03, arei.gong...@huawei.com wrote: > From: Gonglei > > 1. avoid possible superflous checking > 2. make code more robustness > > Signed-off-by: Gonglei > Reviewed-by: Fam Zheng > --- > v3: change the third

Re: [Qemu-block] [PATCH v3] virtio-blk: trivial code optimization

2015-11-09 Thread Gonglei
On 2015/11/9 21:57, Stefan Hajnoczi wrote: > On Mon, Nov 09, 2015 at 05:03:30PM +0800, arei.gong...@huawei.com wrote: >> From: Gonglei >> >> 1. avoid possible superflous checking >> 2. make code more robustness >> >> Signed-off-by: Gonglei >>

[Qemu-block] [PATCH v3] virtio-blk: trivial code optimization

2015-11-09 Thread arei.gonglei
From: Gonglei 1. avoid possible superflous checking 2. make code more robustness Signed-off-by: Gonglei Reviewed-by: Fam Zheng --- v3: change the third condition too [Paolo] add Fam's R-by --- hw/block/virtio-blk.c | 27