Re: [Qemu-block] [PATCH v3 05/15] block/mirror: don't install backing chain on abort

2018-09-05 Thread John Snow
On 09/05/2018 05:54 AM, Kevin Wolf wrote: > Am 04.09.2018 um 21:30 hat Eric Blake geschrieben: >> On 09/04/2018 02:15 PM, John Snow wrote: >> >>> >>> post-script: I really, really hate the "fake cancel" we've implemented >>> for mirror. It makes the job logic so much worse. >> >> Mirror really

Re: [Qemu-block] [PATCH v3 05/15] block/mirror: don't install backing chain on abort

2018-09-05 Thread Kevin Wolf
Am 04.09.2018 um 21:30 hat Eric Blake geschrieben: > On 09/04/2018 02:15 PM, John Snow wrote: > > > > > post-script: I really, really hate the "fake cancel" we've implemented > > for mirror. It makes the job logic so much worse. > > Mirror really does have a tri-state way to end the job (and

Re: [Qemu-block] [PATCH v3 05/15] block/mirror: don't install backing chain on abort

2018-09-04 Thread John Snow
On 09/04/2018 03:30 PM, Eric Blake wrote: > On 09/04/2018 02:15 PM, John Snow wrote: > >> >> post-script: I really, really hate the "fake cancel" we've implemented >> for mirror. It makes the job logic so much worse. > > Mirror really does have a tri-state way to end the job (and accessible >

Re: [Qemu-block] [PATCH v3 05/15] block/mirror: don't install backing chain on abort

2018-09-04 Thread Eric Blake
On 09/04/2018 02:15 PM, John Snow wrote: post-script: I really, really hate the "fake cancel" we've implemented for mirror. It makes the job logic so much worse. Mirror really does have a tri-state way to end the job (and accessible only after the job has moved into the sync state):

Re: [Qemu-block] [PATCH v3 05/15] block/mirror: don't install backing chain on abort

2018-09-04 Thread John Snow
On 09/03/2018 05:24 AM, Max Reitz wrote: > On 2018-09-01 00:28, John Snow wrote: >> In cases where we abort the block/mirror job, there's no point in >> installing the new backing chain before we finish aborting. >> >> Move this to the "success" portion of mirror_exit. >> >> Signed-off-by: John

Re: [Qemu-block] [PATCH v3 05/15] block/mirror: don't install backing chain on abort

2018-09-03 Thread Max Reitz
On 2018-09-01 00:28, John Snow wrote: > In cases where we abort the block/mirror job, there's no point in > installing the new backing chain before we finish aborting. > > Move this to the "success" portion of mirror_exit. > > Signed-off-by: John Snow > --- > block/mirror.c | 27

[Qemu-block] [PATCH v3 05/15] block/mirror: don't install backing chain on abort

2018-08-31 Thread John Snow
In cases where we abort the block/mirror job, there's no point in installing the new backing chain before we finish aborting. Move this to the "success" portion of mirror_exit. Signed-off-by: John Snow --- block/mirror.c | 27 ++- 1 file changed, 14 insertions(+), 13