Re: [Qemu-block] [PATCH v3 1/6] block/nvme: don't touch the completion entries

2019-07-08 Thread Max Reitz
On 08.07.19 14:51, Maxim Levitsky wrote: > On Mon, 2019-07-08 at 14:23 +0200, Max Reitz wrote: >> On 07.07.19 10:43, Maxim Levitsky wrote: >>> On Fri, 2019-07-05 at 13:03 +0200, Max Reitz wrote: On 03.07.19 17:59, Maxim Levitsky wrote: > Completion entries are meant to be only read by the

Re: [Qemu-block] [PATCH v3 1/6] block/nvme: don't touch the completion entries

2019-07-08 Thread Maxim Levitsky
On Mon, 2019-07-08 at 14:23 +0200, Max Reitz wrote: > On 07.07.19 10:43, Maxim Levitsky wrote: > > On Fri, 2019-07-05 at 13:03 +0200, Max Reitz wrote: > > > On 03.07.19 17:59, Maxim Levitsky wrote: > > > > Completion entries are meant to be only read by the host and written by > > > > the device.

Re: [Qemu-block] [PATCH v3 1/6] block/nvme: don't touch the completion entries

2019-07-08 Thread Max Reitz
On 07.07.19 10:43, Maxim Levitsky wrote: > On Fri, 2019-07-05 at 13:03 +0200, Max Reitz wrote: >> On 03.07.19 17:59, Maxim Levitsky wrote: >>> Completion entries are meant to be only read by the host and written by the >>> device. >>> The driver is supposed to scan the completions from the last

Re: [Qemu-block] [PATCH v3 1/6] block/nvme: don't touch the completion entries

2019-07-07 Thread Maxim Levitsky
On Fri, 2019-07-05 at 13:03 +0200, Max Reitz wrote: > On 03.07.19 17:59, Maxim Levitsky wrote: > > Completion entries are meant to be only read by the host and written by the > > device. > > The driver is supposed to scan the completions from the last point where it > > left, > > and until it

Re: [Qemu-block] [PATCH v3 1/6] block/nvme: don't touch the completion entries

2019-07-05 Thread Max Reitz
On 03.07.19 17:59, Maxim Levitsky wrote: > Completion entries are meant to be only read by the host and written by the > device. > The driver is supposed to scan the completions from the last point where it > left, > and until it sees a completion with non flipped phase bit. (Disclaimer: This

[Qemu-block] [PATCH v3 1/6] block/nvme: don't touch the completion entries

2019-07-03 Thread Maxim Levitsky
Completion entries are meant to be only read by the host and written by the device. The driver is supposed to scan the completions from the last point where it left, and until it sees a completion with non flipped phase bit. Signed-off-by: Maxim Levitsky --- block/nvme.c | 5 + 1 file