Re: [Qemu-block] [PATCH v3 5/9] block/mirror: utilize job_exit shim

2018-08-31 Thread Jeff Cody
On Wed, Aug 29, 2018 at 09:57:30PM -0400, John Snow wrote: > Change the manual deferment to mirror_exit into the implicit > callback to job_exit and the mirror_exit callback. > > This does change the order of some bdrv_unref calls and job_completed, > but thanks to the new context in which we call

Re: [Qemu-block] [PATCH v3 5/9] block/mirror: utilize job_exit shim

2018-08-31 Thread Max Reitz
On 2018-08-30 03:57, John Snow wrote: > Change the manual deferment to mirror_exit into the implicit > callback to job_exit and the mirror_exit callback. > > This does change the order of some bdrv_unref calls and job_completed, > but thanks to the new context in which we call .exit, this is safe

[Qemu-block] [PATCH v3 5/9] block/mirror: utilize job_exit shim

2018-08-29 Thread John Snow
Change the manual deferment to mirror_exit into the implicit callback to job_exit and the mirror_exit callback. This does change the order of some bdrv_unref calls and job_completed, but thanks to the new context in which we call .exit, this is safe to defer the possible flushing of any nodes to t