Re: [Qemu-block] [PATCH v4] iothread: fix epollfd leak in the process of delIOThread

On Wed, 05/16 19:43, Peter Xu wrote: > On Wed, May 16, 2018 at 07:14:53PM +0800, WangJie (Pluto) wrote: > > Hi, Peter Xu: > > If call aio_epoll_disable() here, aio_epoll_disable() will return > > before close ctx->epollfd, > > Because the ctx->epoll_enabled is false in the moment. > >

Re: [Qemu-block] [PATCH v4] iothread: fix epollfd leak in the process of delIOThread

I agree, wait for a reply from Fam On 2018/5/16 19:43, Peter Xu wrote: > On Wed, May 16, 2018 at 07:14:53PM +0800, WangJie (Pluto) wrote: >> Hi, Peter Xu: >> If call aio_epoll_disable() here, aio_epoll_disable() will return >> before close ctx->epollfd, >> Because the ctx->epoll_enabled

Re: [Qemu-block] [PATCH v4] iothread: fix epollfd leak in the process of delIOThread

On Wed, May 16, 2018 at 07:14:53PM +0800, WangJie (Pluto) wrote: > Hi, Peter Xu: > If call aio_epoll_disable() here, aio_epoll_disable() will return > before close ctx->epollfd, > Because the ctx->epoll_enabled is false in the moment. > In the process of addIOThread,

Re: [Qemu-block] [PATCH v4] iothread: fix epollfd leak in the process of delIOThread

Hi, Peter Xu: If call aio_epoll_disable() in aio_context_destroy, aio_epoll_disable() will return before close(ctx->epollfd), Because the ctx->epoll_enabled is false in the moment. In the process of addIOThread, aio_context_setup created epoll without call

Re: [Qemu-block] [PATCH v4] iothread: fix epollfd leak in the process of delIOThread

Hi, Peter Xu: If call aio_epoll_disable() here, aio_epoll_disable() will return before close ctx->epollfd, Because the ctx->epoll_enabled is false in the moment. In the process of addIOThread, aio_context_setup created epoll without call aio_epoll_try_enable, so