Re: [Qemu-block] [PATCH v4 05/12] block/nbd: Add nbd_has_filename_options_conflict()

2016-10-13 Thread Kevin Wolf
Am 28.09.2016 um 22:55 hat Max Reitz geschrieben: > Right now, we have four possible options that conflict with specifying > an NBD filename, and a future patch will add another one ("address"). > This future option is a nested QDict that is flattened at this point, > requiring us to test each opti

Re: [Qemu-block] [PATCH v4 05/12] block/nbd: Add nbd_has_filename_options_conflict()

2016-10-04 Thread Max Reitz
On 03.10.2016 20:46, Eric Blake wrote: > On 09/28/2016 03:55 PM, Max Reitz wrote: >> Right now, we have four possible options that conflict with specifying >> an NBD filename, and a future patch will add another one ("address"). >> This future option is a nested QDict that is flattened at this poin

Re: [Qemu-block] [PATCH v4 05/12] block/nbd: Add nbd_has_filename_options_conflict()

2016-10-03 Thread Eric Blake
On 09/28/2016 03:55 PM, Max Reitz wrote: > Right now, we have four possible options that conflict with specifying > an NBD filename, and a future patch will add another one ("address"). > This future option is a nested QDict that is flattened at this point, > requiring us to test each option whethe

[Qemu-block] [PATCH v4 05/12] block/nbd: Add nbd_has_filename_options_conflict()

2016-09-28 Thread Max Reitz
Right now, we have four possible options that conflict with specifying an NBD filename, and a future patch will add another one ("address"). This future option is a nested QDict that is flattened at this point, requiring us to test each option whether its key has an "address." prefix. Therefore, we