Re: [Qemu-block] [PATCH v4 05/15] block/mirror: don't install backing chain on abort

2018-09-07 Thread Max Reitz
On 2018-09-05 17:39, John Snow wrote: > > > On 09/05/2018 06:40 AM, Max Reitz wrote: >> On 2018-09-04 19:09, John Snow wrote: >>> In cases where we abort the block/mirror job, there's no point in >>> installing the new backing chain before we finish aborting. >>> >>> Move this to the "success"

Re: [Qemu-block] [PATCH v4 05/15] block/mirror: don't install backing chain on abort

2018-09-05 Thread John Snow
On 09/05/2018 06:40 AM, Max Reitz wrote: > On 2018-09-04 19:09, John Snow wrote: >> In cases where we abort the block/mirror job, there's no point in >> installing the new backing chain before we finish aborting. >> >> Move this to the "success" portion of mirror_exit. > > Sounds a bit weird

Re: [Qemu-block] [PATCH v4 05/15] block/mirror: don't install backing chain on abort

2018-09-05 Thread Max Reitz
On 2018-09-04 19:09, John Snow wrote: > In cases where we abort the block/mirror job, there's no point in > installing the new backing chain before we finish aborting. > > Move this to the "success" portion of mirror_exit. Sounds a bit weird now that you don't do any moving. > Signed-off-by:

[Qemu-block] [PATCH v4 05/15] block/mirror: don't install backing chain on abort

2018-09-04 Thread John Snow
In cases where we abort the block/mirror job, there's no point in installing the new backing chain before we finish aborting. Move this to the "success" portion of mirror_exit. Signed-off-by: John Snow --- block/mirror.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git