Re: [Qemu-block] [PATCH v5 11/42] block: Add bdrv_supports_compressed_writes()

2019-06-13 Thread Max Reitz
On 13.06.19 15:29, Vladimir Sementsov-Ogievskiy wrote: > 13.06.2019 1:09, Max Reitz wrote: >> Filters cannot compress data themselves but they have to implement >> .bdrv_co_pwritev_compressed() still (or they cannot forward compressed >> writes). Therefore, checking whether >> bs->drv->bdrv_co_pwr

Re: [Qemu-block] [PATCH v5 11/42] block: Add bdrv_supports_compressed_writes()

2019-06-13 Thread Vladimir Sementsov-Ogievskiy
13.06.2019 1:09, Max Reitz wrote: > Filters cannot compress data themselves but they have to implement > .bdrv_co_pwritev_compressed() still (or they cannot forward compressed > writes). Therefore, checking whether > bs->drv->bdrv_co_pwritev_compressed is non-NULL is not sufficient to > know wheth

[Qemu-block] [PATCH v5 11/42] block: Add bdrv_supports_compressed_writes()

2019-06-12 Thread Max Reitz
Filters cannot compress data themselves but they have to implement .bdrv_co_pwritev_compressed() still (or they cannot forward compressed writes). Therefore, checking whether bs->drv->bdrv_co_pwritev_compressed is non-NULL is not sufficient to know whether the node can actually handle compressed w