Re: [Qemu-block] [PATCH v5 16/42] block: Use child access functions when flushing

2019-06-14 Thread Max Reitz
On 14.06.19 16:01, Vladimir Sementsov-Ogievskiy wrote: > 13.06.2019 1:09, Max Reitz wrote: >> If the driver does not support .bdrv_co_flush() so bdrv_co_flush() >> itself has to flush the children of the given node, it should not flush >> just bs->file->bs, but in fact both the child that stores

Re: [Qemu-block] [PATCH v5 16/42] block: Use child access functions when flushing

2019-06-14 Thread Vladimir Sementsov-Ogievskiy
13.06.2019 1:09, Max Reitz wrote: > If the driver does not support .bdrv_co_flush() so bdrv_co_flush() > itself has to flush the children of the given node, it should not flush > just bs->file->bs, but in fact both the child that stores data, and the > one that stores metadata (if they are

[Qemu-block] [PATCH v5 16/42] block: Use child access functions when flushing

2019-06-12 Thread Max Reitz
If the driver does not support .bdrv_co_flush() so bdrv_co_flush() itself has to flush the children of the given node, it should not flush just bs->file->bs, but in fact both the child that stores data, and the one that stores metadata (if they are separate). In any case, the BLKDBG_EVENT()