Re: [Qemu-block] [PATCH v5 20/42] block/snapshot: Fall back to storage child

14.06.2019 19:10, Max Reitz wrote: > On 14.06.19 17:22, Vladimir Sementsov-Ogievskiy wrote: >> 13.06.2019 1:09, Max Reitz wrote: >>> If the top node's driver does not provide snapshot functionality and we >>> want to go down the chain, we should go towards the child which stores >>> the data, i.e.

Re: [Qemu-block] [PATCH v5 20/42] block/snapshot: Fall back to storage child

On 14.06.19 17:22, Vladimir Sementsov-Ogievskiy wrote: > 13.06.2019 1:09, Max Reitz wrote: >> If the top node's driver does not provide snapshot functionality and we >> want to go down the chain, we should go towards the child which stores >> the data, i.e. the storage child. >> >>

Re: [Qemu-block] [PATCH v5 20/42] block/snapshot: Fall back to storage child

13.06.2019 1:09, Max Reitz wrote: > If the top node's driver does not provide snapshot functionality and we > want to go down the chain, we should go towards the child which stores > the data, i.e. the storage child. > > bdrv_snapshot_goto() becomes a bit weird because we may have to redirect >

[Qemu-block] [PATCH v5 20/42] block/snapshot: Fall back to storage child

If the top node's driver does not provide snapshot functionality and we want to go down the chain, we should go towards the child which stores the data, i.e. the storage child. bdrv_snapshot_goto() becomes a bit weird because we may have to redirect the actual child pointer, so it only works if