Re: [Qemu-block] [PATCH v5 21/42] block: Use CAFs for debug breakpoints

2019-06-14 Thread Eric Blake
On 6/14/19 11:12 AM, Max Reitz wrote: > On 14.06.19 17:29, Vladimir Sementsov-Ogievskiy wrote: >> 13.06.2019 1:09, Max Reitz wrote: >>> When looking for a blkdebug node (which implements debug breakpoints), >>> use bdrv_primary_bs() to iterate through the graph, because that is >>> where a blkdebug

Re: [Qemu-block] [PATCH v5 21/42] block: Use CAFs for debug breakpoints

2019-06-14 Thread Max Reitz
On 14.06.19 17:29, Vladimir Sementsov-Ogievskiy wrote: > 13.06.2019 1:09, Max Reitz wrote: >> When looking for a blkdebug node (which implements debug breakpoints), >> use bdrv_primary_bs() to iterate through the graph, because that is >> where a blkdebug node would be. >> >> Signed-off-by: Max Rei

Re: [Qemu-block] [PATCH v5 21/42] block: Use CAFs for debug breakpoints

2019-06-14 Thread Vladimir Sementsov-Ogievskiy
13.06.2019 1:09, Max Reitz wrote: > When looking for a blkdebug node (which implements debug breakpoints), > use bdrv_primary_bs() to iterate through the graph, because that is > where a blkdebug node would be. > > Signed-off-by: Max Reitz Honestly, don't know why blkdebug is always searched in

[Qemu-block] [PATCH v5 21/42] block: Use CAFs for debug breakpoints

2019-06-12 Thread Max Reitz
When looking for a blkdebug node (which implements debug breakpoints), use bdrv_primary_bs() to iterate through the graph, because that is where a blkdebug node would be. Signed-off-by: Max Reitz --- block.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/block.c b/bl