On 09.08.2016 20:39, Reda Sallahi wrote:
> Hi Max,
> Thanks for the review!
>
> On 8/8/16, Max Reitz wrote:
>> On 25.07.2016 07:58, Reda Sallahi wrote:
>>> +if (in->bsz == 0) {
>>> +error_report("invalid number: '%s'", arg);
>>
>> It's not an invalid number, it's just an invalid block
Hi Max,
Thanks for the review!
On 8/8/16, Max Reitz wrote:
> On 25.07.2016 07:58, Reda Sallahi wrote:
>> +if (in->bsz == 0) {
>> +error_report("invalid number: '%s'", arg);
>
> It's not an invalid number, it's just an invalid block size. In my
> understanding, those are two different
Am 25.07.2016 um 07:58 hat Reda Sallahi geschrieben:
> This patch adds a basic dd subcommand analogous to dd(1) to qemu-img.
>
> For the start, this implements the bs, if, of and count options and requires
> both if and of to be specified (no stdin/stdout if not specified) and doesn't
> support tt
On 25.07.2016 07:58, Reda Sallahi wrote:
> This patch adds a basic dd subcommand analogous to dd(1) to qemu-img.
>
> For the start, this implements the bs, if, of and count options and requires
> both if and of to be specified (no stdin/stdout if not specified) and doesn't
> support tty, pipes, et
On Mon, Jul 25, 2016 at 6:58 AM, Reda Sallahi wrote:
> This patch adds a basic dd subcommand analogous to dd(1) to qemu-img.
Ping?
Reda has additional patches on top of this one. It would be good to
get this into the block-next branch so his later work can be merged.
> For the start, this impl
On Mon, Jul 25, 2016 at 6:58 AM, Reda Sallahi wrote:
> This patch adds a basic dd subcommand analogous to dd(1) to qemu-img.
>
> For the start, this implements the bs, if, of and count options and requires
> both if and of to be specified (no stdin/stdout if not specified) and doesn't
> support tt
On Mon, 07/25 07:58, Reda Sallahi wrote:
> This patch adds a basic dd subcommand analogous to dd(1) to qemu-img.
>
> For the start, this implements the bs, if, of and count options and requires
> both if and of to be specified (no stdin/stdout if not specified) and doesn't
> support tty, pipes, et
This patch adds a basic dd subcommand analogous to dd(1) to qemu-img.
For the start, this implements the bs, if, of and count options and requires
both if and of to be specified (no stdin/stdout if not specified) and doesn't
support tty, pipes, etc.
The image format must be specified with -O for
