Re: [Qemu-block] [PATCH v6] ssh: switch from libssh2 to libssh

2019-06-14 Thread Pino Toscano
On Thursday, 13 June 2019 21:41:58 CEST Stefan Weil wrote: > On 12.06.19 15:27, Philippe Mathieu-Daudé wrote: > > Cc'ing Alex (Docker, Travis) and Stefan (MinGW) > [...] > > Note, libssh is not available on MinGW. > > Nor is it available for Mingw64: > >

Re: [Qemu-block] [PATCH v6] ssh: switch from libssh2 to libssh

2019-06-14 Thread Philippe Mathieu-Daudé
On 6/14/19 2:29 PM, Stefan Weil wrote: > On 14.06.19 12:13, Philippe Mathieu-Daudé wrote: >> I agree with Kevin. The only user of the 'ssh' block driver that I am >> aware of is the virt-v2v tool: >> >> http://libguestfs.org/virt-v2v.1.html#convert-from-esxi-hypervisor-over-ssh-to-local-libvirt >>

Re: [Qemu-block] [PATCH v6] ssh: switch from libssh2 to libssh

2019-06-14 Thread Stefan Weil
On 14.06.19 12:13, Philippe Mathieu-Daudé wrote: > I agree with Kevin. The only user of the 'ssh' block driver that I am > aware of is the virt-v2v tool: > > http://libguestfs.org/virt-v2v.1.html#convert-from-esxi-hypervisor-over-ssh-to-local-libvirt > > Stefan, do you think someone would use it

Re: [Qemu-block] [PATCH v6] ssh: switch from libssh2 to libssh

2019-06-14 Thread Philippe Mathieu-Daudé
On 6/14/19 11:42 AM, Kevin Wolf wrote: > Am 13.06.2019 um 21:41 hat Stefan Weil geschrieben: >> On 12.06.19 15:27, Philippe Mathieu-Daudé wrote: >>> Cc'ing Alex (Docker, Travis) and Stefan (MinGW) >> [...] >>> Note, libssh is not available on MinGW. >> >> Nor is it available for Mingw64: Yes, by

Re: [Qemu-block] [PATCH v6] ssh: switch from libssh2 to libssh

2019-06-14 Thread Kevin Wolf
Am 13.06.2019 um 21:41 hat Stefan Weil geschrieben: > On 12.06.19 15:27, Philippe Mathieu-Daudé wrote: > > Cc'ing Alex (Docker, Travis) and Stefan (MinGW) > [...] > > Note, libssh is not available on MinGW. > > Nor is it available for Mingw64: > >

Re: [Qemu-block] [PATCH v6] ssh: switch from libssh2 to libssh

2019-06-13 Thread Stefan Weil
On 12.06.19 15:27, Philippe Mathieu-Daudé wrote: > Cc'ing Alex (Docker, Travis) and Stefan (MinGW) [...] > Note, libssh is not available on MinGW. Nor is it available for Mingw64: https://cygwin.com/cgi-bin2/package-grep.cgi?grep=mingw64-x86_64-libssh=x86_64 That makes building for Windows more

Re: [Qemu-block] [PATCH v6] ssh: switch from libssh2 to libssh

2019-06-13 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Cc'ing Alex (Docker, Travis) and Stefan (MinGW) > > On 6/5/19 11:36 PM, Pino Toscano wrote: >> Rewrite the implementation of the ssh block driver to use libssh instead >> of libssh2. The libssh library has various advantages over libssh2: >> - easier API for

Re: [Qemu-block] [PATCH v6] ssh: switch from libssh2 to libssh

2019-06-12 Thread Philippe Mathieu-Daudé
Cc'ing Alex (Docker, Travis) and Stefan (MinGW) On 6/5/19 11:36 PM, Pino Toscano wrote: > Rewrite the implementation of the ssh block driver to use libssh instead > of libssh2. The libssh library has various advantages over libssh2: > - easier API for authentication (for example for using

[Qemu-block] [PATCH v6] ssh: switch from libssh2 to libssh

2019-06-05 Thread Pino Toscano
Rewrite the implementation of the ssh block driver to use libssh instead of libssh2. The libssh library has various advantages over libssh2: - easier API for authentication (for example for using ssh-agent) - easier API for known_hosts handling - supports newer types of keys in known_hosts Use