Re: [Qemu-block] [PATCH v7 4/5] block: add a 'blockdev-snapshot' QMP command

2015-10-12 Thread Alberto Garcia
On Mon 12 Oct 2015 10:29:35 PM CEST, Max Reitz wrote: >> -if (has_snapshot_node_name && >> -bdrv_lookup_bs(snapshot_node_name, snapshot_node_name, NULL)) { >> -error_setg(errp, "New snapshot node name already in use"); > > There's a difference from v6 here... [...] >> -opti

Re: [Qemu-block] [PATCH v7 4/5] block: add a 'blockdev-snapshot' QMP command

2015-10-12 Thread Max Reitz
On 12.10.2015 11:16, Alberto Garcia wrote: > One of the limitations of the 'blockdev-snapshot-sync' command is that > it does not allow passing BlockdevOptions to the newly created > snapshots, so they are always opened using the default values. > > Extending the command to allow passing options i

[Qemu-block] [PATCH v7 4/5] block: add a 'blockdev-snapshot' QMP command

2015-10-12 Thread Alberto Garcia
One of the limitations of the 'blockdev-snapshot-sync' command is that it does not allow passing BlockdevOptions to the newly created snapshots, so they are always opened using the default values. Extending the command to allow passing options is not a practical solution because there is overlap b