Re: [Qemu-block] [PATCH v8 2/7] block: swap operation order in bdrv_append

2019-06-13 Thread Vladimir Sementsov-Ogievskiy
13.06.2019 16:45, Max Reitz wrote: > On 29.05.19 17:46, Vladimir Sementsov-Ogievskiy wrote: >> bs_top parents may conflict with bs_new backing child permissions, so >> let's do bdrv_replace_node first, it covers more possible cases. >> >> It is needed for further implementation of backup-top

Re: [Qemu-block] [PATCH v8 2/7] block: swap operation order in bdrv_append

2019-06-13 Thread Max Reitz
On 29.05.19 17:46, Vladimir Sementsov-Ogievskiy wrote: > bs_top parents may conflict with bs_new backing child permissions, so > let's do bdrv_replace_node first, it covers more possible cases. > > It is needed for further implementation of backup-top filter, which > don't want to share write

[Qemu-block] [PATCH v8 2/7] block: swap operation order in bdrv_append

2019-05-29 Thread Vladimir Sementsov-Ogievskiy
bs_top parents may conflict with bs_new backing child permissions, so let's do bdrv_replace_node first, it covers more possible cases. It is needed for further implementation of backup-top filter, which don't want to share write permission on its backing child. Side effect is that we may set