Re: [Qemu-block] [PATCH v8 4/7] block: introduce backup-top filter driver

2019-06-18 Thread Vladimir Sementsov-Ogievskiy
18.06.2019 11:20, Kevin Wolf wrote: > Am 18.06.2019 um 09:19 hat Vladimir Sementsov-Ogievskiy geschrieben: >> 17.06.2019 19:25, Kevin Wolf wrote: >>> The first step would be making the block drivers full replacements of >>> the old things, which unfortunately isn't true today. >>> >>> After your

Re: [Qemu-block] [PATCH v8 4/7] block: introduce backup-top filter driver

2019-06-18 Thread Kevin Wolf
Am 18.06.2019 um 09:19 hat Vladimir Sementsov-Ogievskiy geschrieben: > 17.06.2019 19:25, Kevin Wolf wrote: > > The first step would be making the block drivers full replacements of > > the old things, which unfortunately isn't true today. > > > > After your "deal with filters" series, we should

Re: [Qemu-block] [PATCH v8 4/7] block: introduce backup-top filter driver

2019-06-18 Thread Vladimir Sementsov-Ogievskiy
17.06.2019 17:56, Max Reitz wrote: > On 17.06.19 12:36, Vladimir Sementsov-Ogievskiy wrote: >> 14.06.2019 23:03, Max Reitz wrote: >>> On 14.06.19 18:22, Vladimir Sementsov-Ogievskiy wrote: 14.06.2019 15:57, Max Reitz wrote: > On 14.06.19 11:04, Vladimir Sementsov-Ogievskiy wrote: >>

Re: [Qemu-block] [PATCH v8 4/7] block: introduce backup-top filter driver

2019-06-18 Thread Vladimir Sementsov-Ogievskiy
17.06.2019 19:25, Kevin Wolf wrote: > Am 17.06.2019 um 18:01 hat Max Reitz geschrieben: > Should new implicit/explicit > filters be created above or under them? That was always the most difficult question we had when we introduced filters. The problem is that we

Re: [Qemu-block] [PATCH v8 4/7] block: introduce backup-top filter driver

2019-06-17 Thread Kevin Wolf
Am 17.06.2019 um 18:01 hat Max Reitz geschrieben: > >>> Should new implicit/explicit > >>> filters be created above or under them? > >> > >> That was always the most difficult question we had when we introduced > >> filters. > >> > >> The problem is that we never answered it in our code base. > >>

Re: [Qemu-block] [PATCH v8 4/7] block: introduce backup-top filter driver

2019-06-17 Thread Kevin Wolf
Am 17.06.2019 um 16:56 hat Max Reitz geschrieben: > On 17.06.19 12:36, Vladimir Sementsov-Ogievskiy wrote: > > 14.06.2019 23:03, Max Reitz wrote: > >> On 14.06.19 18:22, Vladimir Sementsov-Ogievskiy wrote: > >>> 14.06.2019 15:57, Max Reitz wrote: > On 14.06.19 11:04, Vladimir

Re: [Qemu-block] [PATCH v8 4/7] block: introduce backup-top filter driver

2019-06-17 Thread Max Reitz
On 17.06.19 17:53, Kevin Wolf wrote: > Am 17.06.2019 um 16:56 hat Max Reitz geschrieben: >> On 17.06.19 12:36, Vladimir Sementsov-Ogievskiy wrote: >>> 14.06.2019 23:03, Max Reitz wrote: On 14.06.19 18:22, Vladimir Sementsov-Ogievskiy wrote: > 14.06.2019 15:57, Max Reitz wrote: >> On

Re: [Qemu-block] [PATCH v8 4/7] block: introduce backup-top filter driver

2019-06-17 Thread Max Reitz
On 17.06.19 12:36, Vladimir Sementsov-Ogievskiy wrote: > 14.06.2019 23:03, Max Reitz wrote: >> On 14.06.19 18:22, Vladimir Sementsov-Ogievskiy wrote: >>> 14.06.2019 15:57, Max Reitz wrote: On 14.06.19 11:04, Vladimir Sementsov-Ogievskiy wrote: > 13.06.2019 18:57, Max Reitz wrote: >>

Re: [Qemu-block] [PATCH v8 4/7] block: introduce backup-top filter driver

2019-06-17 Thread Vladimir Sementsov-Ogievskiy
14.06.2019 23:03, Max Reitz wrote: > On 14.06.19 18:22, Vladimir Sementsov-Ogievskiy wrote: >> 14.06.2019 15:57, Max Reitz wrote: >>> On 14.06.19 11:04, Vladimir Sementsov-Ogievskiy wrote: 13.06.2019 18:57, Max Reitz wrote: > On 29.05.19 17:46, Vladimir Sementsov-Ogievskiy wrote: >>

Re: [Qemu-block] [PATCH v8 4/7] block: introduce backup-top filter driver

2019-06-14 Thread Max Reitz
On 14.06.19 18:22, Vladimir Sementsov-Ogievskiy wrote: > 14.06.2019 15:57, Max Reitz wrote: >> On 14.06.19 11:04, Vladimir Sementsov-Ogievskiy wrote: >>> 13.06.2019 18:57, Max Reitz wrote: On 29.05.19 17:46, Vladimir Sementsov-Ogievskiy wrote: > Backup-top filter does copy-before-write

Re: [Qemu-block] [PATCH v8 4/7] block: introduce backup-top filter driver

2019-06-14 Thread Vladimir Sementsov-Ogievskiy
14.06.2019 15:57, Max Reitz wrote: > On 14.06.19 11:04, Vladimir Sementsov-Ogievskiy wrote: >> 13.06.2019 18:57, Max Reitz wrote: >>> On 29.05.19 17:46, Vladimir Sementsov-Ogievskiy wrote: Backup-top filter does copy-before-write operation. It should be inserted above active disk and has

Re: [Qemu-block] [PATCH v8 4/7] block: introduce backup-top filter driver

2019-06-14 Thread Max Reitz
On 14.06.19 11:04, Vladimir Sementsov-Ogievskiy wrote: > 13.06.2019 18:57, Max Reitz wrote: >> On 29.05.19 17:46, Vladimir Sementsov-Ogievskiy wrote: >>> Backup-top filter does copy-before-write operation. It should be >>> inserted above active disk and has a target node for CBW, like the >>>

Re: [Qemu-block] [PATCH v8 4/7] block: introduce backup-top filter driver

2019-06-14 Thread Vladimir Sementsov-Ogievskiy
13.06.2019 18:57, Max Reitz wrote: > On 29.05.19 17:46, Vladimir Sementsov-Ogievskiy wrote: >> Backup-top filter does copy-before-write operation. It should be >> inserted above active disk and has a target node for CBW, like the >> following: >> >> +---+ >> | Guest | >>

Re: [Qemu-block] [PATCH v8 4/7] block: introduce backup-top filter driver

2019-06-13 Thread Max Reitz
On 29.05.19 17:46, Vladimir Sementsov-Ogievskiy wrote: > Backup-top filter does copy-before-write operation. It should be > inserted above active disk and has a target node for CBW, like the > following: > > +---+ > | Guest | > +---+ > |r,w > v >

[Qemu-block] [PATCH v8 4/7] block: introduce backup-top filter driver

2019-05-29 Thread Vladimir Sementsov-Ogievskiy
Backup-top filter does copy-before-write operation. It should be inserted above active disk and has a target node for CBW, like the following: +---+ | Guest | +---+ |r,w v ++ target +---+ | backup_top |-->|