Re: [Qemu-block] [Qemu-devel] [PATCH] mirror: hold aio_context before bdrv_drain

2015-04-01 Thread Bin Wu
On 2015/4/1 19:59, Stefan Hajnoczi wrote: > On Wed, Apr 01, 2015 at 04:49:39PM +0800, Bin Wu wrote: >> >> On 2015/4/1 16:19, Fam Zheng wrote: >>> On Wed, 04/01 12:42, Bin Wu wrote: From: Bin Wu >>> >>> What's the issue are you fixing? I think the coroutine already is running in >>> the AioCon

Re: [Qemu-block] [Qemu-devel] [PATCH] mirror: hold aio_context before bdrv_drain

2015-04-01 Thread Stefan Hajnoczi
On Wed, Apr 01, 2015 at 04:49:39PM +0800, Bin Wu wrote: > > On 2015/4/1 16:19, Fam Zheng wrote: > > On Wed, 04/01 12:42, Bin Wu wrote: > >> From: Bin Wu > > > > What's the issue are you fixing? I think the coroutine already is running in > > the AioContext of bs. > > > > Fam > > > In the curre

Re: [Qemu-block] [Qemu-devel] [PATCH] mirror: hold aio_context before bdrv_drain

2015-04-01 Thread Bin Wu
On 2015/4/1 16:19, Fam Zheng wrote: > On Wed, 04/01 12:42, Bin Wu wrote: >> From: Bin Wu > > What's the issue are you fixing? I think the coroutine already is running in > the AioContext of bs. > > Fam > In the current implementation of bdrv_drain, it should be placed in a critical section as

Re: [Qemu-block] [Qemu-devel] [PATCH] mirror: hold aio_context before bdrv_drain

2015-04-01 Thread Fam Zheng
On Wed, 04/01 12:42, Bin Wu wrote: > From: Bin Wu What's the issue are you fixing? I think the coroutine already is running in the AioContext of bs. Fam > > Signed-off-by: Bin Wu > --- > block/mirror.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/block/mirror.c b/block/mirror.