Re: [Qemu-block] [Qemu-devel] [PATCH 01/34] qdict: Add qdict_array_entries()

2015-05-20 Thread Alberto Garcia
On Fri 08 May 2015 10:06:35 PM CEST, Eric Blake wrote: >> +for (i = 0; i < UINT_MAX; i++) { >> +QObject *subqobj; >> +int subqdict_entries; >> +size_t slen = 32 + subqdict_len; >> +char indexstr[slen], prefix[slen]; > > And more dependence on a working C99 compi

Re: [Qemu-block] [Qemu-devel] [PATCH 01/34] qdict: Add qdict_array_entries()

2015-05-11 Thread Eric Blake
On 05/11/2015 08:40 AM, Kevin Wolf wrote: >>> +char indexstr[slen], prefix[slen]; >> >> And more dependence on a working C99 compiler, thanks to variable length >> array (VLA). >> >>> +size_t snprintf_ret; >>> + >>> +snprintf_ret = snprintf(indexstr, slen, "%s%u", subqdict,

Re: [Qemu-block] [Qemu-devel] [PATCH 01/34] qdict: Add qdict_array_entries()

2015-05-11 Thread Kevin Wolf
Am 08.05.2015 um 22:06 hat Eric Blake geschrieben: > On 05/08/2015 11:21 AM, Kevin Wolf wrote: > > Signed-off-by: Kevin Wolf > > --- > > Might want to include mention of what it will be used for in the commit > body. You're right. This is the new commit message: This counts the entries in a

Re: [Qemu-block] [Qemu-devel] [PATCH 01/34] qdict: Add qdict_array_entries()

2015-05-08 Thread Eric Blake
On 05/08/2015 02:06 PM, Eric Blake wrote: > On 05/08/2015 11:21 AM, Kevin Wolf wrote: >> Signed-off-by: Kevin Wolf >> --- > > Might want to include mention of what it will be used for in the commit > body. > >> include/qapi/qmp/qdict.h | 1 + >> qobject/qdict.c | 68 >> ++

Re: [Qemu-block] [Qemu-devel] [PATCH 01/34] qdict: Add qdict_array_entries()

2015-05-08 Thread Eric Blake
On 05/08/2015 11:21 AM, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- Might want to include mention of what it will be used for in the commit body. > include/qapi/qmp/qdict.h | 1 + > qobject/qdict.c | 68 > +--- > 2 files changed, 65