Re: [Qemu-block] [Qemu-devel] [PATCH 2/2] qapi: add transaction support for x-block-dirty-bitmap-merge

2018-07-06 Thread Eric Blake
On 07/06/2018 10:38 AM, John Snow wrote: I think the "discard stashed state, making undo impossible" interpretation is good because .commit() is not allowed to fail. That function should only do things that never fail. I think this is probably the correct way to proceed, and we ought to

Re: [Qemu-block] [Qemu-devel] [PATCH 2/2] qapi: add transaction support for x-block-dirty-bitmap-merge

2018-07-06 Thread Vladimir Sementsov-Ogievskiy
06.07.2018 18:38, John Snow wrote: On 07/06/2018 06:12 AM, Vladimir Sementsov-Ogievskiy wrote: Ok, let's go this way for now, I'll rewrite it. Last requirement looks a bit strange for me in transaction context. We should not assume that action is done before commit. What is main idea of

Re: [Qemu-block] [Qemu-devel] [PATCH 2/2] qapi: add transaction support for x-block-dirty-bitmap-merge

2018-07-06 Thread John Snow
On 07/06/2018 06:12 AM, Vladimir Sementsov-Ogievskiy wrote: > > Ok, let's go this way for now, I'll rewrite it. > > Last requirement looks a bit strange for me in transaction context. We > should not assume that action is done before commit. > What is main idea of transaction action, do

Re: [Qemu-block] [Qemu-devel] [PATCH 2/2] qapi: add transaction support for x-block-dirty-bitmap-merge

2018-07-06 Thread Vladimir Sementsov-Ogievskiy
05.07.2018 23:40, John Snow wrote: On 07/03/2018 06:53 AM, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy --- qapi/transaction.json | 2 ++ blockdev.c| 53 ++- 2 files changed, 54 insertions(+),

Re: [Qemu-block] [Qemu-devel] [PATCH 2/2] qapi: add transaction support for x-block-dirty-bitmap-merge

2018-07-05 Thread John Snow
On 07/03/2018 06:53 AM, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > qapi/transaction.json | 2 ++ > blockdev.c| 53 > ++- > 2 files changed, 54 insertions(+), 1 deletion(-) > > diff