Peter Xu writes:
> Suggested-by: Paolo Bonzini
> CC: Markus Armbruster
> CC: Kevin Wolf
> CC: qemu-block@nongnu.org
> Signed-off-by: Peter Xu
> ---
> block/qapi.c | 5 -
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/block/qapi.c b/block/qapi.c
> index db2d3fb..687e577
On Tue, 03/08 09:12, Markus Armbruster wrote:
> Peter Xu writes:
>
> > Suggested-by: Paolo Bonzini
> > CC: Markus Armbruster
> > CC: Kevin Wolf
> > CC: qemu-block@nongnu.org
> > Signed-off-by: Peter Xu
> > ---
> > block/qapi.c | 5 -
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
On 08/03/2016 09:12, Markus Armbruster wrote:
> I'm afraid this isn't a good idea. It relies on the non-local argument
> that nobody will ever put a key longer than 255 into a qdict that gets
> dumped. That may even be the case, but you need to *prove* it, not just
> assert it. The weakest acc
Fam Zheng writes:
> On Tue, 03/08 09:12, Markus Armbruster wrote:
>> Peter Xu writes:
>>
>> > Suggested-by: Paolo Bonzini
>> > CC: Markus Armbruster
>> > CC: Kevin Wolf
>> > CC: qemu-block@nongnu.org
>> > Signed-off-by: Peter Xu
>> > ---
>> > block/qapi.c | 5 -
>> > 1 file changed, 4
Peter Xu writes:
> On Tue, Mar 08, 2016 at 09:12:45AM +0100, Markus Armbruster wrote:
>> Peter Xu writes:
>> > const char *format = composite ? "%*s%s:\n" : "%*s%s: ";
>>
>> Unrelated to your patch: ugh!
>>
>> Printf formats should be literals whenever possible, to make it easy for
>>
On Tue, Mar 08, 2016 at 09:12:45AM +0100, Markus Armbruster wrote:
> Peter Xu writes:
> > const char *format = composite ? "%*s%s:\n" : "%*s%s: ";
>
> Unrelated to your patch: ugh!
>
> Printf formats should be literals whenever possible, to make it easy for
> the compiler to warn you wh
On Tue, Mar 08, 2016 at 02:47:31PM +0100, Markus Armbruster wrote:
> Fam Zheng writes:
> > Also I think the double underscore identifiers are considered reserved in C,
> > no?
>
> Correct. C99 7.1.3 Reserved identifiers: All identifiers that begin
> with an underscore and either an uppercase let
On Tue, Mar 08, 2016 at 01:17:03PM +0100, Paolo Bonzini wrote:
>
>
> On 08/03/2016 09:12, Markus Armbruster wrote:
> > I'm afraid this isn't a good idea. It relies on the non-local argument
> > that nobody will ever put a key longer than 255 into a qdict that gets
> > dumped. That may even be t