Re: [Qemu-block] [Qemu-devel] [PATCH 3/4] qdev-properties-system: Improve error message for drive assignment conflict

2015-06-22 Thread Markus Armbruster
Peter Maydell writes: > On 22 June 2015 at 10:12, Markus Armbruster wrote: >> We generally do not end error messages with a period. >> >> The message for auto_claimed drives is of the form >> >> LOCATION: This went wrong. Advice on how to fix it. >> >> All in one awfully long line. A frien

Re: [Qemu-block] [Qemu-devel] [PATCH 3/4] qdev-properties-system: Improve error message for drive assignment conflict

2015-06-22 Thread Peter Maydell
On 22 June 2015 at 10:12, Markus Armbruster wrote: > I think we should just bite the bullet and extend Error to support > additional helpful information for humans. ...I thought all of the string was already just helpful information for humans? I certainly hope we aren't expecting anybody to pars

Re: [Qemu-block] [Qemu-devel] [PATCH 3/4] qdev-properties-system: Improve error message for drive assignment conflict

2015-06-22 Thread Markus Armbruster
Peter Maydell writes: > If the user forgot if=none on their drive specification they're likely > to get an error message because the drive is assigned once automatically > by QEMU and once by the manual id=/drive= user command line specification. > Improve the error message produced in this case