Re: [Qemu-block] [Qemu-devel] [PATCH 6/8] fdc: Disentangle phases in fdctrl_read_data()

2015-05-20 Thread John Snow
On 05/20/2015 04:25 AM, Kevin Wolf wrote: > Am 19.05.2015 um 22:40 hat John Snow geschrieben: >> >> >> On 05/19/2015 11:36 AM, Kevin Wolf wrote: >>> This commit makes similar improvements as have already been made to the >>> write function: Instead of relying on a flag in the MSR to distinguish >

Re: [Qemu-block] [Qemu-devel] [PATCH 6/8] fdc: Disentangle phases in fdctrl_read_data()

2015-05-20 Thread Kevin Wolf
Am 19.05.2015 um 22:40 hat John Snow geschrieben: > > > On 05/19/2015 11:36 AM, Kevin Wolf wrote: > > This commit makes similar improvements as have already been made to the > > write function: Instead of relying on a flag in the MSR to distinguish > > controller phases, use the explicit phase th

Re: [Qemu-block] [Qemu-devel] [PATCH 6/8] fdc: Disentangle phases in fdctrl_read_data()

2015-05-19 Thread John Snow
On 05/19/2015 11:36 AM, Kevin Wolf wrote: > This commit makes similar improvements as have already been made to the > write function: Instead of relying on a flag in the MSR to distinguish > controller phases, use the explicit phase that we store now. Assertions > of the right MSR flags are added