On 07/31/2017 12:04 AM, Jeff Cody wrote: > Right now, all qemu-iotests output data into the same scratch directory, > and so each tests needs to be responsible for cleanup up its own files.
And, tests must either use unique names or else cannot be run in parallel. > > Have each test use 'scratch/$seq' as its temp directory, so the check > script can do simple cleanup of removing the whole temporary directory. It also makes it much nicer for a potential future patch to parallelize things, now that every tests' temporary files are uniquely named by virtue of the subdirectory. > > Signed-off-by: Jeff Cody <jc...@redhat.com> > --- > tests/qemu-iotests/check | 21 +++++++++++++++++---- > 1 file changed, 17 insertions(+), 4 deletions(-) > > @@ -300,13 +301,23 @@ do > fi > export OUTPUT_DIR=$PWD > if $debug; then > - (cd "$source_iotests"; > + ( > + cd "$source_iotests"; Pre-existing; but we should check that the 'cd' succeeded (if not, the rest of the code is at risk of doing things in the wrong directory). Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
