Re: [Qemu-block] [Qemu-devel] [PATCH v2 0/3] blockdev: Defer creation of implicit PCI devices for IF_VIRTIO drives

2015-06-09 Thread Peter Maydell
On 9 June 2015 at 18:48, Peter Maydell wrote: > Patch 3 is the one-liner to change the default-drive-type. Unfortunately > just doing that alone will break commandlines that currently work The other problem with taking patch 3 alone is that it completely breaks everything, because: * by default

Re: [Qemu-block] [Qemu-devel] [PATCH v2 0/3] blockdev: Defer creation of implicit PCI devices for IF_VIRTIO drives

2015-06-09 Thread Peter Maydell
On 9 June 2015 at 18:48, Peter Maydell wrote: > 1) explicit if=foo drive manually wired up to a device is an error >(and always diagnosed as such, not indirectly via it being double-used) I had a look at getting this to be diagnosed properly, and the sketch of the patch is: 1. add "bool auto_

Re: [Qemu-block] [Qemu-devel] [PATCH v2 0/3] blockdev: Defer creation of implicit PCI devices for IF_VIRTIO drives

2015-06-20 Thread Markus Armbruster
Peter Maydell writes: > This is a respin of the patchset I sent out last week; the > only change v1->v2 is to drop the special casing of S390, as > Christian confirmed it isn't needed. This collapses the old > patches 2/3 into one. > > I'm going to use this cover letter as an opportunity to (a) h

Re: [Qemu-block] [Qemu-devel] [PATCH v2 0/3] blockdev: Defer creation of implicit PCI devices for IF_VIRTIO drives

2015-06-20 Thread Markus Armbruster
Peter Maydell writes: > On 9 June 2015 at 18:48, Peter Maydell wrote: >> Patch 3 is the one-liner to change the default-drive-type. Unfortunately >> just doing that alone will break commandlines that currently work > > The other problem with taking patch 3 alone is that it completely > breaks ev

Re: [Qemu-block] [Qemu-devel] [PATCH v2 0/3] blockdev: Defer creation of implicit PCI devices for IF_VIRTIO drives

2015-06-20 Thread Peter Maydell
On 20 June 2015 at 16:00, Markus Armbruster wrote: > Peter Maydell writes: >> I do definitely want to enable short-options for virt for 2.4... > > "Enable short options" = change virt's default block interface type from > IF_IDE to IF_VIRTIO, I presume. > > "For 2.4" rules out solutions requiring

Re: [Qemu-block] [Qemu-devel] [PATCH v2 0/3] blockdev: Defer creation of implicit PCI devices for IF_VIRTIO drives

2015-06-20 Thread Markus Armbruster
Peter Maydell writes: > On 9 June 2015 at 18:48, Peter Maydell wrote: >> 1) explicit if=foo drive manually wired up to a device is an error >>(and always diagnosed as such, not indirectly via it being double-used) > > I had a look at getting this to be diagnosed properly, and the sketch > of

Re: [Qemu-block] [Qemu-devel] [PATCH v2 0/3] blockdev: Defer creation of implicit PCI devices for IF_VIRTIO drives

2015-06-20 Thread Markus Armbruster
Peter Maydell writes: > On 20 June 2015 at 16:00, Markus Armbruster wrote: >> Peter Maydell writes: >>> I do definitely want to enable short-options for virt for 2.4... >> >> "Enable short options" = change virt's default block interface type from >> IF_IDE to IF_VIRTIO, I presume. >> >> "For 2