Re: [Qemu-block] [Qemu-devel] [PATCH v2 1/2] block/accounting: introduce latency histogram

2018-03-08 Thread Eric Blake
On 03/08/2018 12:58 PM, Vladimir Sementsov-Ogievskiy wrote: Hm. these numbers are actually boundary points of histogram intervals, not intervals itself. And, wiki says "The bins are usually specified as consecutive, non-overlapping intervals of a variable.", so, intervals are bins. So, what

Re: [Qemu-block] [Qemu-devel] [PATCH v2 1/2] block/accounting: introduce latency histogram

2018-03-08 Thread Vladimir Sementsov-Ogievskiy
08.03.2018 21:21, Vladimir Sementsov-Ogievskiy wrote: 08.03.2018 21:14, Vladimir Sementsov-Ogievskiy wrote: 08.03.2018 20:31, Eric Blake wrote: On 03/06/2018 09:32 AM, Stefan Hajnoczi wrote: On Wed, Feb 07, 2018 at 03:50:36PM +0300, Vladimir Sementsov-Ogievskiy wrote: Introduce latency

Re: [Qemu-block] [Qemu-devel] [PATCH v2 1/2] block/accounting: introduce latency histogram

2018-03-08 Thread Vladimir Sementsov-Ogievskiy
08.03.2018 21:14, Vladimir Sementsov-Ogievskiy wrote: 08.03.2018 20:31, Eric Blake wrote: On 03/06/2018 09:32 AM, Stefan Hajnoczi wrote: On Wed, Feb 07, 2018 at 03:50:36PM +0300, Vladimir Sementsov-Ogievskiy wrote: Introduce latency histogram statics for block devices. For each accounted

Re: [Qemu-block] [Qemu-devel] [PATCH v2 1/2] block/accounting: introduce latency histogram

2018-03-08 Thread Vladimir Sementsov-Ogievskiy
08.03.2018 20:31, Eric Blake wrote: On 03/06/2018 09:32 AM, Stefan Hajnoczi wrote: On Wed, Feb 07, 2018 at 03:50:36PM +0300, Vladimir Sementsov-Ogievskiy wrote: Introduce latency histogram statics for block devices. For each accounted operation type latency region [0, +inf) is divided into

Re: [Qemu-block] [Qemu-devel] [PATCH v2 1/2] block/accounting: introduce latency histogram

2018-03-08 Thread Eric Blake
On 03/06/2018 09:32 AM, Stefan Hajnoczi wrote: On Wed, Feb 07, 2018 at 03:50:36PM +0300, Vladimir Sementsov-Ogievskiy wrote: Introduce latency histogram statics for block devices. For each accounted operation type latency region [0, +inf) is divided into subregions by several points. Then,

Re: [Qemu-block] [Qemu-devel] [PATCH v2 1/2] block/accounting: introduce latency histogram

2018-03-06 Thread Stefan Hajnoczi
On Wed, Feb 07, 2018 at 03:50:36PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Introduce latency histogram statics for block devices. > For each accounted operation type latency region [0, +inf) is > divided into subregions by several points. Then, calculate > hits for each subregion. > >