Re: [Qemu-block] [Qemu-devel] [PATCH v2 31/32] qcow2: Allow configuring the L2 slice size

2018-01-22 Thread Alberto Garcia
On Tue 16 Jan 2018 05:57:22 PM CET, Anton Nefedov wrote: >> -r->l2_slice_size = s->cluster_size / sizeof(uint64_t); >> -r->l2_table_cache = qcow2_cache_create(bs, l2_cache_size); >> -r->refcount_block_cache = qcow2_cache_create(bs, refcount_cache_size); >> +l2_cache_size *=

Re: [Qemu-block] [Qemu-devel] [PATCH v2 31/32] qcow2: Allow configuring the L2 slice size

2018-01-18 Thread Alberto Garcia
On Wed 17 Jan 2018 12:18:25 AM CET, Eric Blake wrote: > Is there a QMP counterpart to the command-line option? Not in this revision, but I'll add one. Berto

Re: [Qemu-block] [Qemu-devel] [PATCH v2 31/32] qcow2: Allow configuring the L2 slice size

2018-01-16 Thread Eric Blake
On 12/15/2017 06:53 AM, Alberto Garcia wrote: > Now that the code is ready to handle L2 slices we can finally add an > option to allow configuring their size. > > An L2 slice is the portion of an L2 table that is read by the qcow2 > cache. Until now the cache was always reading full L2 tables,

Re: [Qemu-block] [Qemu-devel] [PATCH v2 31/32] qcow2: Allow configuring the L2 slice size

2018-01-16 Thread Anton Nefedov
On 15/12/2017 3:53 PM, Alberto Garcia wrote: diff --git a/block/qcow2-cache.c b/block/qcow2-cache.c index 2fcecbd7a8..fe58d1ec70 100644 --- a/block/qcow2-cache.c +++ b/block/qcow2-cache.c [..] @@ -879,9 +896,13 @@ static int qcow2_update_options_prepare(BlockDriverState *bs, }