Re: [Qemu-block] [Qemu-devel] [PATCH v3 2/3] block/backup: avoid copying less than full target clusters

2016-02-24 Thread Eric Blake
On 02/23/2016 05:52 PM, John Snow wrote: > "Couldn't determine the cluster size of the target image, which has no > backing file" is more correct. The problem is not why we couldn't > determine it, but instead that we were unable to AND there is no backing > file, so our inability to determine it

Re: [Qemu-block] [Qemu-devel] [PATCH v3 2/3] block/backup: avoid copying less than full target clusters

2016-02-23 Thread John Snow
On 02/23/2016 07:45 PM, Eric Blake wrote: > On 02/23/2016 05:27 PM, Fam Zheng wrote: >> On Tue, 02/23 19:17, John Snow wrote: >>> During incremental backups, if the target has a cluster size that is >>> larger than the backup cluster size and we are backing up to a target >>> that cannot (for

Re: [Qemu-block] [Qemu-devel] [PATCH v3 2/3] block/backup: avoid copying less than full target clusters

2016-02-23 Thread Eric Blake
On 02/23/2016 05:27 PM, Fam Zheng wrote: > On Tue, 02/23 19:17, John Snow wrote: >> During incremental backups, if the target has a cluster size that is >> larger than the backup cluster size and we are backing up to a target >> that cannot (for whichever reason) pull clusters up from a backing