Re: [Qemu-block] [Qemu-devel] [PATCH v4 07/10] qapi: Don't special-case simple union wrappers

2016-03-08 Thread Markus Armbruster
Eric Blake writes: > Simple unions were carrying a special case that hid their 'data' > QMP member from the resulting C struct, via the hack method > QAPISchemaObjectTypeVariant.simple_union_type(). But by using > the work we started by unboxing flat union and alternate > branches, coupled with

Re: [Qemu-block] [Qemu-devel] [PATCH v4 07/10] qapi: Don't special-case simple union wrappers

2016-03-08 Thread Eric Blake
On 03/08/2016 08:59 AM, Markus Armbruster wrote: > Eric Blake writes: > >> Simple unions were carrying a special case that hid their 'data' >> QMP member from the resulting C struct, via the hack method >> QAPISchemaObjectTypeVariant.simple_union_type(). But by using >> the work we started by un

Re: [Qemu-block] [Qemu-devel] [PATCH v4 07/10] qapi: Don't special-case simple union wrappers

2016-03-08 Thread Markus Armbruster
Eric Blake writes: > On 03/08/2016 08:59 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> Simple unions were carrying a special case that hid their 'data' >>> QMP member from the resulting C struct, via the hack method >>> QAPISchemaObjectTypeVariant.simple_union_type(). But by using