Re: [Qemu-block] [Qemu-devel] [PATCH v4 5/5] raw-posix: Introduce hdev_is_sg()

2015-06-22 Thread Dimitris Aragiorgis
Hello Stefan, Yes, you are right. Using realpath() is a workaround for supporting symlinks, as long as they point to a path starting with /dev/sg. I will remove this reference in the revised version of this patch. However, it still holds that determining whether a filename is an SG device or not

Re: [Qemu-block] [Qemu-devel] [PATCH v4 5/5] raw-posix: Introduce hdev_is_sg()

2015-06-22 Thread Stefan Hajnoczi
On Mon, Jun 22, 2015 at 01:18:43PM +0300, Dimitris Aragiorgis wrote: So I suggest we go with the submitted patch taking into account Eric's proposal: The code first stat()s the given filename to ensure it is a character device node, and then it issues the SG_GET_VERSION_NUM and SG_GET_SCSI_ID