Re: [Qemu-block] [Qemu-devel] [PATCH v6 3/4] qmp: add monitor command to add/remove a child

2015-11-13 Thread Kevin Wolf
Am 13.11.2015 um 11:25 hat Wen Congyang geschrieben: > On 11/10/2015 09:40 AM, Wen Congyang wrote: > > On 11/10/2015 12:04 AM, Kevin Wolf wrote: > >> Am 16.10.2015 um 10:57 hat Wen Congyang geschrieben: > >>> +## > >>> +# @ChangeOperation: > >>> +# > >>> +# An enumeration of block device change

Re: [Qemu-block] [Qemu-devel] [PATCH v6 3/4] qmp: add monitor command to add/remove a child

2015-11-13 Thread Wen Congyang
On 11/10/2015 09:40 AM, Wen Congyang wrote: > On 11/10/2015 12:04 AM, Kevin Wolf wrote: >> Am 16.10.2015 um 10:57 hat Wen Congyang geschrieben: >>> +## >>> +# @ChangeOperation: >>> +# >>> +# An enumeration of block device change operation. >>> +# >>> +# @add: Add a new block driver state to a

Re: [Qemu-block] [Qemu-devel] [PATCH v6 3/4] qmp: add monitor command to add/remove a child

2015-11-10 Thread Markus Armbruster
Wen Congyang writes: > On 11/09/2015 10:42 PM, Alberto Garcia wrote: >> Sorry again for the late review, here are my comments: >> >> On Fri 16 Oct 2015 10:57:45 AM CEST, Wen Congyang wrote: >>> +void qmp_x_blockdev_change(ChangeOperation op, const char *parent, >>> +