Re: [Qemu-block] [RFC] QMP design: Fixing query-block and friends

2017-07-05 Thread Stefan Hajnoczi
On Tue, Jun 27, 2017 at 02:24:12PM -0400, John Snow wrote: > On 06/27/2017 12:31 PM, Kevin Wolf wrote: > > If that's what we're going to do, I think I can figure out something > > nice for block nodes. That shouldn't be too hard. The only question > > would be whether we want a command to query

Re: [Qemu-block] [RFC] QMP design: Fixing query-block and friends

2017-06-30 Thread Alberto Garcia
On Fri 30 Jun 2017 04:22:11 PM CEST, Kevin Wolf wrote: > Am 30.06.2017 um 15:01 hat Alberto Garcia geschrieben: >> On Tue 27 Jun 2017 06:31:45 PM CEST, Kevin Wolf wrote: >> > * Speaking of recursion: ImageInfo recursively includes information >> > about all images in the backing chain. This is

Re: [Qemu-block] [RFC] QMP design: Fixing query-block and friends

2017-06-30 Thread Kevin Wolf
Am 30.06.2017 um 15:01 hat Alberto Garcia geschrieben: > On Tue 27 Jun 2017 06:31:45 PM CEST, Kevin Wolf wrote: > > * Speaking of recursion: ImageInfo recursively includes information > > about all images in the backing chain. This is what makes the output > > of query-named-block-nodes so

Re: [Qemu-block] [RFC] QMP design: Fixing query-block and friends

2017-06-30 Thread Alberto Garcia
On Tue 27 Jun 2017 06:31:45 PM CEST, Kevin Wolf wrote: > * Speaking of recursion: ImageInfo recursively includes information > about all images in the backing chain. This is what makes the output > of query-named-block-nodes so redundant. It is also inconsistent > because the runtime

Re: [Qemu-block] [RFC] QMP design: Fixing query-block and friends

2017-06-27 Thread John Snow
On 06/27/2017 12:31 PM, Kevin Wolf wrote: > Hi, > > I haven't really liked query-block for a long time, but now that > blockdev-add and -blockdev have settled, it might finally be the time to > actually do something about it. In fact, if used together with these > modern interfaces, our query

Re: [Qemu-block] [RFC] QMP design: Fixing query-block and friends

2017-06-27 Thread Eric Blake
On 06/27/2017 11:31 AM, Kevin Wolf wrote: > Hi, > > I haven't really liked query-block for a long time, but now that > blockdev-add and -blockdev have settled, it might finally be the time to > actually do something about it. In fact, if used together with these > modern interfaces, our query

[Qemu-block] [RFC] QMP design: Fixing query-block and friends

2017-06-27 Thread Kevin Wolf
Hi, I haven't really liked query-block for a long time, but now that blockdev-add and -blockdev have settled, it might finally be the time to actually do something about it. In fact, if used together with these modern interfaces, our query commands are simply broken, so we have to fix something.