Re: [Qemu-block] [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-16 Thread Kashyap Chamarthy
On Fri, Jul 13, 2018 at 01:35:02PM +0200, Cornelia Huck wrote: > On Thu, 12 Jul 2018 17:47:00 +0200 > Thomas Huth wrote: > > On 12.07.2018 08:32, Markus Armbruster wrote: > > > Daniel P. Berrangé writes: [...] > > > Our tool to help with getting cc: wrong less often is the MAINTAINERS > > >

Re: [Qemu-block] [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-11 Thread Kashyap Chamarthy
On Tue, Jul 10, 2018 at 05:01:22PM +0200, Cornelia Huck wrote: [...] > Who is, in general, testing which libvirt version? I can think of: > - libvirt developers, which will probably run libvirt current git, but > more likely a released QEMU? > - QEMU (and other related tools) developers, who

Re: [Qemu-block] [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-10 Thread Daniel P . Berrangé
On Tue, Jul 10, 2018 at 04:09:38PM +0100, Peter Maydell wrote: > On 10 July 2018 at 15:22, Cornelia Huck wrote: > > On Tue, 10 Jul 2018 07:59:15 +0200 > > Markus Armbruster wrote: > > > >> In addition to actively pulling libvirt developers into review of > >> deprecation patches, we should

Re: [Qemu-block] [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-03 Thread Christian Borntraeger
On 07/03/2018 01:35 PM, Peter Maydell wrote: > On 3 July 2018 at 12:32, Kevin Wolf wrote: >> Am 03.07.2018 um 13:22 hat Daniel P. Berrangé geschrieben: >>> Just posted latest version here: >>> >>> https://www.redhat.com/archives/libvir-list/2018-July/msg00130.html >>> >>> It will be in the

Re: [Qemu-block] [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-03 Thread Daniel P . Berrangé
On Tue, Jul 03, 2018 at 01:32:29PM +0200, Kevin Wolf wrote: > Am 03.07.2018 um 13:22 hat Daniel P. Berrangé geschrieben: > > On Tue, Jul 03, 2018 at 12:53:44PM +0200, Christian Borntraeger wrote: > > > > > > > > > On 07/02/2018 10:04 AM, Kevin Wolf wrote: > > > > Am 25.06.2018 um 13:45 hat Peter

Re: [Qemu-block] [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-03 Thread Peter Maydell
On 3 July 2018 at 12:32, Kevin Wolf wrote: > Am 03.07.2018 um 13:22 hat Daniel P. Berrangé geschrieben: >> Just posted latest version here: >> >> https://www.redhat.com/archives/libvir-list/2018-July/msg00130.html >> >> It will be in the next release on ~ Aug 1st > > It would have been a lot

Re: [Qemu-block] [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-03 Thread Kevin Wolf
Am 03.07.2018 um 13:22 hat Daniel P. Berrangé geschrieben: > On Tue, Jul 03, 2018 at 12:53:44PM +0200, Christian Borntraeger wrote: > > > > > > On 07/02/2018 10:04 AM, Kevin Wolf wrote: > > > Am 25.06.2018 um 13:45 hat Peter Krempa geschrieben: > > >> On Mon, Jun 25, 2018 at 13:41:06 +0200,

Re: [Qemu-block] [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-03 Thread Daniel P . Berrangé
On Tue, Jul 03, 2018 at 12:53:44PM +0200, Christian Borntraeger wrote: > > > On 07/02/2018 10:04 AM, Kevin Wolf wrote: > > Am 25.06.2018 um 13:45 hat Peter Krempa geschrieben: > >> On Mon, Jun 25, 2018 at 13:41:06 +0200, Kevin Wolf wrote: > >>> Am 25.06.2018 um 11:53 hat Daniel P. Berrangé

Re: [Qemu-block] [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-03 Thread Christian Borntraeger
On 07/02/2018 10:04 AM, Kevin Wolf wrote: > Am 25.06.2018 um 13:45 hat Peter Krempa geschrieben: >> On Mon, Jun 25, 2018 at 13:41:06 +0200, Kevin Wolf wrote: >>> Am 25.06.2018 um 11:53 hat Daniel P. Berrangé geschrieben: On Fri, Jun 22, 2018 at 03:31:46PM +0100, Daniel P. Berrangé wrote:

Re: [Qemu-block] [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-02 Thread Kevin Wolf
Am 25.06.2018 um 13:45 hat Peter Krempa geschrieben: > On Mon, Jun 25, 2018 at 13:41:06 +0200, Kevin Wolf wrote: > > Am 25.06.2018 um 11:53 hat Daniel P. Berrangé geschrieben: > > > On Fri, Jun 22, 2018 at 03:31:46PM +0100, Daniel P. Berrangé wrote: > > > > On Fri, Jun 22, 2018 at 04:25:13PM

Re: [Qemu-block] [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-25 Thread Peter Krempa
On Mon, Jun 25, 2018 at 13:41:06 +0200, Kevin Wolf wrote: > Am 25.06.2018 um 11:53 hat Daniel P. Berrangé geschrieben: > > On Fri, Jun 22, 2018 at 03:31:46PM +0100, Daniel P. Berrangé wrote: > > > On Fri, Jun 22, 2018 at 04:25:13PM +0200, Kevin Wolf wrote: > > > > Am 22.06.2018 um 15:36 hat

Re: [Qemu-block] [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-25 Thread Kevin Wolf
Am 25.06.2018 um 11:53 hat Daniel P. Berrangé geschrieben: > On Fri, Jun 22, 2018 at 03:31:46PM +0100, Daniel P. Berrangé wrote: > > On Fri, Jun 22, 2018 at 04:25:13PM +0200, Kevin Wolf wrote: > > > Am 22.06.2018 um 15:36 hat Christian Borntraeger geschrieben: > > > > > > > > > > > > On

Re: [Qemu-block] [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-25 Thread Daniel P . Berrangé
On Fri, Jun 22, 2018 at 03:31:46PM +0100, Daniel P. Berrangé wrote: > On Fri, Jun 22, 2018 at 04:25:13PM +0200, Kevin Wolf wrote: > > Am 22.06.2018 um 15:36 hat Christian Borntraeger geschrieben: > > > > > > > > > On 06/22/2018 02:55 PM, Kevin Wolf wrote: > > > > Am 22.06.2018 um 13:38 hat

Re: [Qemu-block] [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-25 Thread Peter Krempa
On Fri, Jun 22, 2018 at 14:55:02 +0200, Kevin Wolf wrote: > Am 22.06.2018 um 13:38 hat Christian Borntraeger geschrieben: > > > > On 06/15/2018 04:21 PM, Kevin Wolf wrote: > > > The -drive option serial was deprecated in QEMU 2.10. It's time to > > > remove it. > > > > > > Tests need to be

Re: [Qemu-block] [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-22 Thread Eric Blake
On 06/22/2018 09:30 AM, Daniel P. Berrangé wrote: Perhaps we could use a more structured notification, to make detecting use of deprecated features programmatically trivial. A QMP event might do. Libvirt currently has CI that is largely focused on unit testing. We recently did some work,

Re: [Qemu-block] [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-22 Thread Daniel P . Berrangé
On Fri, Jun 22, 2018 at 04:25:13PM +0200, Kevin Wolf wrote: > Am 22.06.2018 um 15:36 hat Christian Borntraeger geschrieben: > > > > > > On 06/22/2018 02:55 PM, Kevin Wolf wrote: > > > Am 22.06.2018 um 13:38 hat Christian Borntraeger geschrieben: > > >> > > >> On 06/15/2018 04:21 PM, Kevin Wolf

Re: [Qemu-block] [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-22 Thread Daniel P . Berrangé
On Fri, Jun 22, 2018 at 03:25:19PM +0100, Daniel P. Berrangé wrote: > On Fri, Jun 22, 2018 at 04:19:29PM +0200, Markus Armbruster wrote: > > Kevin Wolf writes: > > > > > Am 22.06.2018 um 13:38 hat Christian Borntraeger geschrieben: > > >> > > >> On 06/15/2018 04:21 PM, Kevin Wolf wrote: > > >>

Re: [Qemu-block] [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-22 Thread Daniel P . Berrangé
On Fri, Jun 22, 2018 at 04:19:29PM +0200, Markus Armbruster wrote: > Kevin Wolf writes: > > > Am 22.06.2018 um 13:38 hat Christian Borntraeger geschrieben: > >> > >> On 06/15/2018 04:21 PM, Kevin Wolf wrote: > >> > The -drive option serial was deprecated in QEMU 2.10. It's time to > >> > remove

Re: [Qemu-block] [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

2018-06-22 Thread Daniel P . Berrangé
On Fri, Jun 22, 2018 at 03:36:50PM +0200, Christian Borntraeger wrote: > > > On 06/22/2018 02:55 PM, Kevin Wolf wrote: > > Am 22.06.2018 um 13:38 hat Christian Borntraeger geschrieben: > >> > >> On 06/15/2018 04:21 PM, Kevin Wolf wrote: > >>> The -drive option serial was deprecated in QEMU 2.10.