Re: [Qemu-block] backup notifier fail policy

2016-10-04 Thread Stefan Hajnoczi
On Mon, Oct 03, 2016 at 02:07:34PM -0400, John Snow wrote: > > > On 10/03/2016 09:11 AM, Stefan Hajnoczi wrote: > > On Fri, Sep 30, 2016 at 09:59:16PM +0300, Vladimir Sementsov-Ogievskiy > > wrote: > > > On 30.09.2016 20:11, Vladimir Sementsov-Ogievskiy wrote: > > > > Hi all! > > > > > > > > Pl

Re: [Qemu-block] backup notifier fail policy

2016-10-03 Thread John Snow
On 10/03/2016 09:11 AM, Stefan Hajnoczi wrote: On Fri, Sep 30, 2016 at 09:59:16PM +0300, Vladimir Sementsov-Ogievskiy wrote: On 30.09.2016 20:11, Vladimir Sementsov-Ogievskiy wrote: Hi all! Please, can somebody explain me, why we fail guest request in case of io error in write notifier? I th

Re: [Qemu-block] backup notifier fail policy

2016-10-03 Thread Stefan Hajnoczi
On Fri, Sep 30, 2016 at 09:59:16PM +0300, Vladimir Sementsov-Ogievskiy wrote: > On 30.09.2016 20:11, Vladimir Sementsov-Ogievskiy wrote: > > Hi all! > > > > Please, can somebody explain me, why we fail guest request in case of io > > error in write notifier? I think guest consistency is more impor

Re: [Qemu-block] backup notifier fail policy

2016-09-30 Thread Vladimir Sementsov-Ogievskiy
On 30.09.2016 20:11, Vladimir Sementsov-Ogievskiy wrote: Hi all! Please, can somebody explain me, why we fail guest request in case of io error in write notifier? I think guest consistency is more important than success of unfinished backup. Or, what am I missing? I'm saying about this code:

[Qemu-block] backup notifier fail policy

2016-09-30 Thread Vladimir Sementsov-Ogievskiy
Hi all! Please, can somebody explain me, why we fail guest request in case of io error in write notifier? I think guest consistency is more important than success of unfinished backup. Or, what am I missing? I'm saying about this code: static int coroutine_fn backup_before_write_notify(