Re: [Qemu-block] coroutines: block: Co-routine re-entered recursively when migrating disk with iothreads

2016-06-09 Thread Paolo Bonzini
> BTW this doesn't mean that the blockjobs AioContext following problem > is solved. AioContexts can still change if the guest resets the > virtio device, for example. > > I suspect we'll still hit undefined behavior when that happens. I agree... :/ Paolo

Re: [Qemu-block] coroutines: block: Co-routine re-entered recursively when migrating disk with iothreads

2016-06-09 Thread Stefan Hajnoczi
On Thu, Jun 9, 2016 at 9:47 AM, Stefan Hajnoczi wrote: > On Thu, Jun 9, 2016 at 9:25 AM, Paolo Bonzini wrote: >> On 09/06/2016 09:35, Stefan Hajnoczi wrote: >>> >>> if (s->dataplane) { >>> virtio_blk_data_plane_stop(s->dataplane); >>> }

Re: [Qemu-block] coroutines: block: Co-routine re-entered recursively when migrating disk with iothreads

2016-06-09 Thread Paolo Bonzini
On 09/06/2016 09:35, Stefan Hajnoczi wrote: > > if (s->dataplane) { > virtio_blk_data_plane_stop(s->dataplane); > } > > virtio_save(vdev, f); > } > > We reach the situation I described where BDS AioContext changes but > mirror_run() is still in the IOThread AioContext.

Re: [Qemu-block] coroutines: block: Co-routine re-entered recursively when migrating disk with iothreads

2016-05-23 Thread Fam Zheng
On Mon, 05/23 14:54, Jason J. Herne wrote: > Using libvirt to migrate a guest and one guest disk that is using iothreads > causes Qemu to crash with the message: > Co-routine re-entered recursively > > I've looked into this one a bit but I have not seen anything that > immediately stands out. >

[Qemu-block] coroutines: block: Co-routine re-entered recursively when migrating disk with iothreads

2016-05-23 Thread Jason J. Herne
Using libvirt to migrate a guest and one guest disk that is using iothreads causes Qemu to crash with the message: Co-routine re-entered recursively I've looked into this one a bit but I have not seen anything that immediately stands out. Here is what I have found: In qemu_coroutine_enter: