Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-23 Thread Daniel P . Berrangé
On Fri, Jun 23, 2023 at 10:51:53AM -0400, Peter Xu wrote: > On Fri, Jun 23, 2023 at 09:23:18AM +0100, Daniel P. Berrangé wrote: > > On Thu, Jun 22, 2023 at 11:54:43AM -0400, Peter Xu wrote: > > > On Thu, Jun 22, 2023 at 10:59:58AM +0100, Daniel P. Berrangé wrote: > > > > I've mentioned several time

Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-23 Thread Peter Xu
On Fri, Jun 23, 2023 at 09:23:18AM +0100, Daniel P. Berrangé wrote: > On Thu, Jun 22, 2023 at 11:54:43AM -0400, Peter Xu wrote: > > On Thu, Jun 22, 2023 at 10:59:58AM +0100, Daniel P. Berrangé wrote: > > > I've mentioned several times before that the user should never need to > > > set this multifd

Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-23 Thread Peter Xu
On Fri, Jun 23, 2023 at 08:17:46AM +0100, Daniel P. Berrangé wrote: > On Thu, Jun 22, 2023 at 03:20:01PM -0400, Peter Xu wrote: > > On Thu, Jun 22, 2023 at 05:33:29PM +0100, Daniel P. Berrangé wrote: > > > On Thu, Jun 22, 2023 at 11:54:43AM -0400, Peter Xu wrote: > > > > I can try to move the todo

Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-23 Thread Daniel P . Berrangé
On Thu, Jun 22, 2023 at 11:54:43AM -0400, Peter Xu wrote: > On Thu, Jun 22, 2023 at 10:59:58AM +0100, Daniel P. Berrangé wrote: > > I've mentioned several times before that the user should never need to > > set this multifd-channels parameter (nor many other parameters) on the > > destination in th

Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-23 Thread Daniel P . Berrangé
On Thu, Jun 22, 2023 at 03:20:01PM -0400, Peter Xu wrote: > On Thu, Jun 22, 2023 at 05:33:29PM +0100, Daniel P. Berrangé wrote: > > On Thu, Jun 22, 2023 at 11:54:43AM -0400, Peter Xu wrote: > > > I can try to move the todo even higher. Trying to list the initial goals > > > here: > > > > > > - On

Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-22 Thread Juan Quintela
Peter Xu wrote: > On Thu, Jun 22, 2023 at 11:22:56AM +0200, Thomas Huth wrote: >> Then simply forbid "migrate_set_parameter multifd-channels ..." if the uri >> has been specified on the command line? > > Yeah, actually already in a pull (even though the pr may need a new one..): > > https://lore.k

Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-22 Thread Juan Quintela
Peter Xu wrote: > On Mon, Jun 12, 2023 at 10:51:08PM +0200, Juan Quintela wrote: >> Peter Xu wrote: >> > On Mon, Jun 12, 2023 at 09:33:42PM +0200, Juan Quintela wrote: >> >> Only "defer" is recommended. After setting all migation parameters, >> >> start incoming migration with "migrate-incoming

Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-22 Thread Peter Xu
On Thu, Jun 22, 2023 at 05:33:29PM +0100, Daniel P. Berrangé wrote: > On Thu, Jun 22, 2023 at 11:54:43AM -0400, Peter Xu wrote: > > I can try to move the todo even higher. Trying to list the initial goals > > here: > > > > - One extra phase of handshake between src/dst (maybe the time to boost >

Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-22 Thread Juan Quintela
Juan Quintela wrote: > Only "defer" is recommended. After setting all migation parameters, > start incoming migration with "migrate-incoming uri" command. > > Signed-off-by: Juan Quintela Nack myself. Dropped on next submissiong. keyfile properties suggested by paolo is a much better suggesti

Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-22 Thread Daniel P . Berrangé
On Thu, Jun 22, 2023 at 11:54:43AM -0400, Peter Xu wrote: > I can try to move the todo even higher. Trying to list the initial goals > here: > > - One extra phase of handshake between src/dst (maybe the time to boost > QEMU_VM_FILE_VERSION) before anything else happens. > > - Dest shouldn't ne

Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-22 Thread Paolo Bonzini
On Thu, Jun 22, 2023 at 5:26 PM Peter Xu wrote: > PS: we may want to postpone this to be later than migration_object_init(), > when/if there's a real patch. Yes, that's true. > > > The only incompatibility is for people who are using "," in an URI, > > > which is rare and only an issue for the "

Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-22 Thread Peter Xu
On Thu, Jun 22, 2023 at 10:59:58AM +0100, Daniel P. Berrangé wrote: > On Thu, Jun 22, 2023 at 10:52:12AM +0200, Juan Quintela wrote: > > Paolo Bonzini wrote: > > > On 6/12/23 22:51, Juan Quintela wrote: > > >>> Shall we just leave it there? Or is deprecating it helps us in any > > >>> form? > >

Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-22 Thread Peter Xu
On Thu, Jun 22, 2023 at 11:22:56AM +0200, Thomas Huth wrote: > Then simply forbid "migrate_set_parameter multifd-channels ..." if the uri > has been specified on the command line? Yeah, actually already in a pull (even though the pr may need a new one..): https://lore.kernel.org/r/20230622021320.

Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-22 Thread Peter Xu
On Thu, Jun 22, 2023 at 12:01:55PM +0200, Juan Quintela wrote: > Paolo Bonzini wrote: > > On 6/22/23 10:52, Juan Quintela wrote: > >> User friendliness. > >> The problem is that if you use more than two channels with multifd, on > >> the incoming side, you need to do: > > > > You're sacrificing us

Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-22 Thread Juan Quintela
Paolo Bonzini wrote: > On 6/22/23 10:52, Juan Quintela wrote: >> User friendliness. >> The problem is that if you use more than two channels with multifd, on >> the incoming side, you need to do: > > You're sacrificing user-friendliness for the 99.99% that don't use > multifd, for an error (i.e. i

Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-22 Thread Daniel P . Berrangé
On Thu, Jun 22, 2023 at 10:52:12AM +0200, Juan Quintela wrote: > Paolo Bonzini wrote: > > On 6/12/23 22:51, Juan Quintela wrote: > >>> Shall we just leave it there? Or is deprecating it helps us in any form? > >> See the patches two weeks ago when people complained that lisen(.., num) > >> was to

Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-22 Thread Paolo Bonzini
On 6/22/23 10:52, Juan Quintela wrote: User friendliness. The problem is that if you use more than two channels with multifd, on the incoming side, you need to do: You're sacrificing user-friendliness for the 99.99% that don't use multifd, for an error (i.e. it's not even fixing the issue) f

Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-22 Thread Thomas Huth
On 22/06/2023 10.52, Juan Quintela wrote: Paolo Bonzini wrote: On 6/12/23 22:51, Juan Quintela wrote: Shall we just leave it there? Or is deprecating it helps us in any form? See the patches two weeks ago when people complained that lisen(.., num) was too low. And there are other parameters

Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-22 Thread Juan Quintela
Paolo Bonzini wrote: > On 6/12/23 22:51, Juan Quintela wrote: >>> Shall we just leave it there? Or is deprecating it helps us in any form? >> See the patches two weeks ago when people complained that lisen(.., num) >> was too low. And there are other parameters that work the same way >> (that I

Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-22 Thread Paolo Bonzini
On 6/21/23 09:08, Thomas Huth wrote:   if (strcmp(incoming, "defer") != 0) { +    warn_report("-incoming %s is deprecated, use -incoming defer and " +    " set the uri with migrate-incoming.", incoming);   qmp_migrate_incoming(incoming, &local_e

Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-22 Thread Paolo Bonzini
On 6/12/23 22:51, Juan Quintela wrote: Shall we just leave it there? Or is deprecating it helps us in any form? See the patches two weeks ago when people complained that lisen(.., num) was too low. And there are other parameters that work the same way (that I convenientely had forgotten). So

Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-21 Thread Juan Quintela
Thomas Huth wrote: > On 12/06/2023 21.33, Juan Quintela wrote: >> Only "defer" is recommended. After setting all migation parameters, >> start incoming migration with "migrate-incoming uri" command. >> Signed-off-by: Juan Quintela >> --- >> docs/about/deprecated.rst | 7 +++ >> softmmu/vl

Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-21 Thread Thomas Huth
On 12/06/2023 21.33, Juan Quintela wrote: Only "defer" is recommended. After setting all migation parameters, start incoming migration with "migrate-incoming uri" command. Signed-off-by: Juan Quintela --- docs/about/deprecated.rst | 7 +++ softmmu/vl.c | 2 ++ 2 files chan

Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-20 Thread Peter Xu
On Tue, Jun 20, 2023 at 01:10:55PM +0100, Daniel P. Berrangé wrote: > In some cases it is worth having a convenience option for user friendliness. > > In this case, however, users are already needing to use QMP/HMP on the > source side to set migration parameters. I think it is reasonable to say >

Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-20 Thread Daniel P . Berrangé
On Mon, Jun 12, 2023 at 05:19:40PM -0400, Peter Xu wrote: > On Mon, Jun 12, 2023 at 10:51:08PM +0200, Juan Quintela wrote: > > Peter Xu wrote: > > > On Mon, Jun 12, 2023 at 09:33:42PM +0200, Juan Quintela wrote: > > >> Only "defer" is recommended. After setting all migation parameters, > > >> sta

Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-20 Thread Daniel P . Berrangé
On Mon, Jun 12, 2023 at 10:51:08PM +0200, Juan Quintela wrote: > Peter Xu wrote: > > On Mon, Jun 12, 2023 at 09:33:42PM +0200, Juan Quintela wrote: > >> Only "defer" is recommended. After setting all migation parameters, > >> start incoming migration with "migrate-incoming uri" command. > >> > >

Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-12 Thread Peter Xu
On Mon, Jun 12, 2023 at 10:51:08PM +0200, Juan Quintela wrote: > Peter Xu wrote: > > On Mon, Jun 12, 2023 at 09:33:42PM +0200, Juan Quintela wrote: > >> Only "defer" is recommended. After setting all migation parameters, > >> start incoming migration with "migrate-incoming uri" command. > >> > >

Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-12 Thread Juan Quintela
Peter Xu wrote: > On Mon, Jun 12, 2023 at 09:33:42PM +0200, Juan Quintela wrote: >> Only "defer" is recommended. After setting all migation parameters, >> start incoming migration with "migrate-incoming uri" command. >> >> Signed-off-by: Juan Quintela >> --- >> docs/about/deprecated.rst | 7 ++

Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-12 Thread Peter Xu
On Mon, Jun 12, 2023 at 09:33:42PM +0200, Juan Quintela wrote: > Only "defer" is recommended. After setting all migation parameters, > start incoming migration with "migrate-incoming uri" command. > > Signed-off-by: Juan Quintela > --- > docs/about/deprecated.rst | 7 +++ > softmmu/vl.c

[RFC 4/6] migration: Deprecate -incoming

2023-06-12 Thread Juan Quintela
Only "defer" is recommended. After setting all migation parameters, start incoming migration with "migrate-incoming uri" command. Signed-off-by: Juan Quintela --- docs/about/deprecated.rst | 7 +++ softmmu/vl.c | 2 ++ 2 files changed, 9 insertions(+) diff --git a/docs/about/d