Hello Markus,
On Fri, 13 Oct 2023 15:28, Markus Armbruster wrote:
The commit message needs to explain why.
Certainly.
This is wrong. docs/devel/style.rst:
Include directives
--
Order include directives as follows:
.. code-block:: c
#include "qemu/osde
The commit message needs to explain why.
Emmanouil Pitsidianakis writes:
> Signed-off-by: Emmanouil Pitsidianakis
> ---
> audio/pwaudio.c | 8
> hw/arm/smmuv3.c | 2 +-
> include/qemu/compiler.h | 30 +++---
> include/qemu/osdep
On Fri, 13 Oct 2023 at 11:16, Daniel P. Berrangé wrote:
> This patch (and all the others in the series) have a ridiculously
> large context either side of the change. It makes this horrible
> to review as it requires wading through pages of pre-existing code
> trying to spot the change.
>
> Please
On Fri, Oct 13, 2023 at 10:47:05AM +0300, Emmanouil Pitsidianakis wrote:
> Signed-off-by: Emmanouil Pitsidianakis
> ---
> audio/pwaudio.c | 8
> hw/arm/smmuv3.c | 2 +-
> include/qemu/compiler.h | 30 +++---
> include/qemu/osdep.h
Signed-off-by: Emmanouil Pitsidianakis
---
audio/pwaudio.c | 8
hw/arm/smmuv3.c | 2 +-
include/qemu/compiler.h | 30 +++---
include/qemu/osdep.h | 4 ++--
target/loongarch/cpu.c | 4 ++--
target/loongarch/translate
