Re: [RFC PATCH 12/22] nbd/server: Simplify export shutdown

2020-08-19 Thread Eric Blake
On 8/13/20 11:29 AM, Kevin Wolf wrote: Closing export is somewhat convoluted because nbd_export_close() and nbd_export_put() call each other and the ways they actually end up being nested is not necessarily obvious. You are in a maze of twisty little passages, all alike. Yes, I've always hated

Re: [RFC PATCH 12/22] nbd/server: Simplify export shutdown

2020-08-17 Thread Max Reitz
On 13.08.20 18:29, Kevin Wolf wrote: > Closing export is somewhat convoluted because nbd_export_close() and > nbd_export_put() call each other and the ways they actually end up being > nested is not necessarily obvious. > > However, it is not really necessary to call nbd_export_close() from > nbd_

[RFC PATCH 12/22] nbd/server: Simplify export shutdown

2020-08-13 Thread Kevin Wolf
Closing export is somewhat convoluted because nbd_export_close() and nbd_export_put() call each other and the ways they actually end up being nested is not necessarily obvious. However, it is not really necessary to call nbd_export_close() from nbd_export_put() when putting the last reference beca