Re: [RFC PATCH v1 3/7] char-socket: initialize reconnect timer only if close is emitted

2020-04-27 Thread Dima Stepanov
On Sun, Apr 26, 2020 at 03:26:58PM +0800, Li Feng wrote: > This patch is trying to fix the same issue with me. > However, our fix is different. > > I think that check the s->reconnect_timer is better. I also thought about your solution: - if (s->reconnect_time) { + if (s->reconnect_time &&

Re: [RFC PATCH v1 3/7] char-socket: initialize reconnect timer only if close is emitted

2020-04-26 Thread Li Feng
This patch is trying to fix the same issue with me. However, our fix is different. I think that check the s->reconnect_timer is better. Thanks, Feng Li Marc-André Lureau 于2020年4月24日周五 上午3:16写道: > > Hi > > On Thu, Apr 23, 2020 at 8:41 PM Dima Stepanov wrote: > > > > During vhost-user

[RFC PATCH v1 3/7] char-socket: initialize reconnect timer only if close is emitted

2020-04-23 Thread Dima Stepanov
During vhost-user reconnect functionality testing the following assert was hit: qemu-system-x86_64: chardev/char-socket.c:125: qemu_chr_socket_restart_timer: Assertion `!s->reconnect_timer' failed. Aborted (core dumped) This is observed only if the connection is closed by the vhost-user-blk

Re: [RFC PATCH v1 3/7] char-socket: initialize reconnect timer only if close is emitted

2020-04-23 Thread Marc-André Lureau
Hi On Thu, Apr 23, 2020 at 8:41 PM Dima Stepanov wrote: > > During vhost-user reconnect functionality testing the following assert > was hit: > qemu-system-x86_64: chardev/char-socket.c:125: > qemu_chr_socket_restart_timer: Assertion `!s->reconnect_timer' failed. > Aborted (core dumped)