Re: [RFC PATCH v2 1/4] block: Allow changing bs->file on reopen

2021-02-16 Thread Alberto Garcia
On Wed 10 Feb 2021 05:52:47 PM CET, Kevin Wolf wrote: >> +/* The 'file' option only allows strings */ >> +assert(qobject_type(value) == QTYPE_QSTRING); > > This is true, but not entirely obvious: The QAPI schema has > BlockdevRef, which can be either a string or a dict. However, we're > dea

Re: [RFC PATCH v2 1/4] block: Allow changing bs->file on reopen

2021-02-10 Thread Kevin Wolf
Am 08.02.2021 um 19:44 hat Alberto Garcia geschrieben: > When the x-blockdev-reopen was added it allowed reconfiguring the > graph by replacing backing files, but changing the 'file' option was > forbidden. Because of this restriction some operations are not > possible, notably inserting and removi

Re: [RFC PATCH v2 1/4] block: Allow changing bs->file on reopen

2021-02-09 Thread Vladimir Sementsov-Ogievskiy
08.02.2021 21:44, Alberto Garcia wrote: When the x-blockdev-reopen was added it allowed reconfiguring the graph by replacing backing files, but changing the 'file' option was forbidden. Because of this restriction some operations are not possible, notably inserting and removing block filters. Th

[RFC PATCH v2 1/4] block: Allow changing bs->file on reopen

2021-02-08 Thread Alberto Garcia
When the x-blockdev-reopen was added it allowed reconfiguring the graph by replacing backing files, but changing the 'file' option was forbidden. Because of this restriction some operations are not possible, notably inserting and removing block filters. This patch adds support for replacing the 'f