Re: [RFC PATCH v2 19/19] hw/usb: Inline usb_bus_from_device()

2023-02-13 Thread Philippe Mathieu-Daudé
On 13/2/23 10:11, Thomas Huth wrote: On 13/02/2023 09.44, Philippe Mathieu-Daudé wrote: On 13/2/23 09:11, Thomas Huth wrote: On 13/02/2023 08.08, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- RFC Other devices don't use such helper. Maybe it should be the other

Re: [RFC PATCH v2 19/19] hw/usb: Inline usb_bus_from_device()

2023-02-13 Thread Thomas Huth
On 13/02/2023 09.44, Philippe Mathieu-Daudé wrote: On 13/2/23 09:11, Thomas Huth wrote: On 13/02/2023 08.08, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- RFC Other devices don't use such helper. Maybe it should be the other way around, introduce more bus_from_de

Re: [RFC PATCH v2 19/19] hw/usb: Inline usb_bus_from_device()

2023-02-13 Thread Philippe Mathieu-Daudé
On 13/2/23 09:11, Thomas Huth wrote: On 13/02/2023 08.08, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- RFC Other devices don't use such helper. Maybe it should be the other way around, introduce more bus_from_device() helpers? ---   hw/usb/bus.c    | 10

Re: [RFC PATCH v2 19/19] hw/usb: Inline usb_bus_from_device()

2023-02-13 Thread Thomas Huth
On 13/02/2023 08.08, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- RFC Other devices don't use such helper. Maybe it should be the other way around, introduce more bus_from_device() helpers? --- hw/usb/bus.c| 10 +- hw/usb/core.c | 6

[RFC PATCH v2 19/19] hw/usb: Inline usb_bus_from_device()

2023-02-12 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- RFC Other devices don't use such helper. Maybe it should be the other way around, introduce more bus_from_device() helpers? --- hw/usb/bus.c| 10 +- hw/usb/core.c | 6 +++--- hw/usb/dev-hub.c| 4 ++-- hw/usb/dev-serial.