Re: [RFC PATCH v3 04/27] qcow2: Add get_l2_entry() and set_l2_entry()

2020-02-20 Thread Alberto Garcia
On Thu 20 Feb 2020 04:22:24 PM CET, Eric Blake wrote: >> +++ b/block/qcow2.h > > scripts/git.orderfile can be used to hoist this part of the patch to > the front of the message (as it is more valuable to review first). I didn't know that git had this feature, thanks for the tip! Berto

Re: [RFC PATCH v3 04/27] qcow2: Add get_l2_entry() and set_l2_entry()

2020-02-20 Thread Max Reitz
On 22.12.19 12:36, Alberto Garcia wrote: > The size of an L2 entry is 64 bits, but if we want to have subclusters > we need extended L2 entries. This means that we have to access L2 > tables and slices differently depending on whether an image has > extended L2 entries or not. > > This patch

Re: [RFC PATCH v3 04/27] qcow2: Add get_l2_entry() and set_l2_entry()

2020-02-20 Thread Eric Blake
On 12/22/19 5:36 AM, Alberto Garcia wrote: The size of an L2 entry is 64 bits, but if we want to have subclusters we need extended L2 entries. This means that we have to access L2 tables and slices differently depending on whether an image has extended L2 entries or not. This patch replaces all

[RFC PATCH v3 04/27] qcow2: Add get_l2_entry() and set_l2_entry()

2019-12-22 Thread Alberto Garcia
The size of an L2 entry is 64 bits, but if we want to have subclusters we need extended L2 entries. This means that we have to access L2 tables and slices differently depending on whether an image has extended L2 entries or not. This patch replaces all l2_slice[] accesses with calls to