In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword.
Signed-off-by: Emmanouil Pitsidianakis <manos.pitsidiana...@linaro.org> --- nbd/client.c | 4 ++-- nbd/common.c | 2 +- qemu-nbd.c | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/nbd/client.c b/nbd/client.c index 29ffc609a4..04507249b2 100644 --- a/nbd/client.c +++ b/nbd/client.c @@ -1051,7 +1051,7 @@ int nbd_receive_negotiate(QIOChannel *ioc, QCryptoTLSCreds *tlscreds, } info->base_allocation = result == 1; } - /* fall through */ + fallthrough; case NBD_MODE_SIMPLE: /* Try NBD_OPT_GO first - if it works, we are done (it * also gives us a good message if the server requires @@ -1074,7 +1074,7 @@ int nbd_receive_negotiate(QIOChannel *ioc, QCryptoTLSCreds *tlscreds, if (nbd_receive_query_exports(ioc, info->name, errp) < 0) { return -EINVAL; } - /* fall through */ + fallthrough; case NBD_MODE_EXPORT_NAME: /* write the export name request */ if (nbd_send_option_request(ioc, NBD_OPT_EXPORT_NAME, -1, info->name, diff --git a/nbd/common.c b/nbd/common.c index 3247c1d618..1140ea0888 100644 --- a/nbd/common.c +++ b/nbd/common.c @@ -249,7 +249,7 @@ int nbd_errno_to_system_errno(int err) break; default: trace_nbd_unknown_error(err); - /* fallthrough */ + fallthrough; case NBD_EINVAL: ret = EINVAL; break; diff --git a/qemu-nbd.c b/qemu-nbd.c index 186e6468b1..41e50208a5 100644 --- a/qemu-nbd.c +++ b/qemu-nbd.c @@ -632,7 +632,7 @@ int main(int argc, char **argv) break; case 'n': optarg = (char *) "none"; - /* fallthrough */ + fallthrough; case QEMU_NBD_OPT_CACHE: if (seen_cache) { error_report("-n and --cache can only be specified once"); @@ -708,7 +708,7 @@ int main(int argc, char **argv) } else { sn_id_or_name = optarg; } - /* fall through */ + fallthrough; case 'r': readonly = true; flags &= ~BDRV_O_RDWR; -- 2.39.2