Re: [RFC v2] migration: Add migrate-set-bitmap-node-mapping

2020-06-02 Thread Peter Krempa
On Tue, Jun 02, 2020 at 12:56:32 +0200, Max Reitz wrote: > On 18.05.20 18:26, Peter Krempa wrote: > > On Wed, May 13, 2020 at 16:56:10 +0200, Max Reitz wrote: > >> This command allows mapping block node names to aliases for the purpose > >> of block dirty bitmap migration. > >> > >> This way,

Re: [RFC v2] migration: Add migrate-set-bitmap-node-mapping

2020-06-02 Thread Max Reitz
On 18.05.20 18:26, Peter Krempa wrote: > On Wed, May 13, 2020 at 16:56:10 +0200, Max Reitz wrote: >> This command allows mapping block node names to aliases for the purpose >> of block dirty bitmap migration. >> >> This way, management tools can use different node names on the source >> and

Re: [RFC v2] migration: Add migrate-set-bitmap-node-mapping

2020-05-18 Thread Vladimir Sementsov-Ogievskiy
18.05.2020 21:20, Peter Krempa wrote: On Mon, May 18, 2020 at 20:52:32 +0300, Vladimir Sementsov-Ogievskiy wrote: [add Nikolay] 18.05.2020 19:26, Peter Krempa wrote: On Wed, May 13, 2020 at 16:56:10 +0200, Max Reitz wrote: [...] Is there any difference of handling of persistent and

Re: [RFC v2] migration: Add migrate-set-bitmap-node-mapping

2020-05-18 Thread Peter Krempa
On Mon, May 18, 2020 at 20:52:32 +0300, Vladimir Sementsov-Ogievskiy wrote: > [add Nikolay] > > 18.05.2020 19:26, Peter Krempa wrote: > > On Wed, May 13, 2020 at 16:56:10 +0200, Max Reitz wrote: [...] > > Is there any difference of handling of persistent and non-persistent > > bitmaps?

Re: [RFC v2] migration: Add migrate-set-bitmap-node-mapping

2020-05-18 Thread Vladimir Sementsov-Ogievskiy
[add Nikolay] 18.05.2020 19:26, Peter Krempa wrote: On Wed, May 13, 2020 at 16:56:10 +0200, Max Reitz wrote: This command allows mapping block node names to aliases for the purpose of block dirty bitmap migration. This way, management tools can use different node names on the source and

Re: [RFC v2] migration: Add migrate-set-bitmap-node-mapping

2020-05-18 Thread Peter Krempa
On Wed, May 13, 2020 at 16:56:10 +0200, Max Reitz wrote: > This command allows mapping block node names to aliases for the purpose > of block dirty bitmap migration. > > This way, management tools can use different node names on the source > and destination and pass the mapping of how bitmaps are

Re: [RFC v2] migration: Add migrate-set-bitmap-node-mapping

2020-05-14 Thread Kevin Wolf
Am 14.05.2020 um 09:13 hat Max Reitz geschrieben: > On 13.05.20 18:11, Eric Blake wrote: > > On 5/13/20 9:56 AM, Max Reitz wrote: > >> This command allows mapping block node names to aliases for the purpose > >> of block dirty bitmap migration. > >> > >> This way, management tools can use

Re: [RFC v2] migration: Add migrate-set-bitmap-node-mapping

2020-05-14 Thread Kevin Wolf
Am 14.05.2020 um 11:09 hat Max Reitz geschrieben: > On 13.05.20 22:09, Vladimir Sementsov-Ogievskiy wrote: > [...] > > 1. So, you decided to make only node-mapping, not bitmap-mapping, so we > > can't rename bitmaps in-flight and can't migrate bitmaps from one node > > to several and visa-versa. I

Re: [RFC v2] migration: Add migrate-set-bitmap-node-mapping

2020-05-14 Thread Vladimir Sementsov-Ogievskiy
14.05.2020 12:09, Max Reitz wrote: On 13.05.20 22:09, Vladimir Sementsov-Ogievskiy wrote: [...] 1. So, you decided to make only node-mapping, not bitmap-mapping, so we can't rename bitmaps in-flight and can't migrate bitmaps from one node to several and visa-versa. I think it's OK, nothing good

Re: [RFC v2] migration: Add migrate-set-bitmap-node-mapping

2020-05-14 Thread Dr. David Alan Gilbert
* Max Reitz (mre...@redhat.com) wrote: > On 14.05.20 10:42, Dr. David Alan Gilbert wrote: > > * Max Reitz (mre...@redhat.com) wrote: > > > > > > > >> +void qmp_migrate_set_bitmap_node_mapping(MigrationBlockNodeMappingList > >> *mapping, > >> + Error

Re: [RFC v2] migration: Add migrate-set-bitmap-node-mapping

2020-05-14 Thread Max Reitz
On 13.05.20 22:09, Vladimir Sementsov-Ogievskiy wrote: [...] > 1. So, you decided to make only node-mapping, not bitmap-mapping, so we > can't rename bitmaps in-flight and can't migrate bitmaps from one node > to several and visa-versa. I think it's OK, nothing good in such > possibilities, and

Re: [RFC v2] migration: Add migrate-set-bitmap-node-mapping

2020-05-14 Thread Max Reitz
On 14.05.20 10:42, Dr. David Alan Gilbert wrote: > * Max Reitz (mre...@redhat.com) wrote: > > > >> +void qmp_migrate_set_bitmap_node_mapping(MigrationBlockNodeMappingList >> *mapping, >> + Error **errp) >> +{ >> +QDict *in_mapping = qdict_new(); >> +

Re: [RFC v2] migration: Add migrate-set-bitmap-node-mapping

2020-05-14 Thread Dr. David Alan Gilbert
* Max Reitz (mre...@redhat.com) wrote: > +void qmp_migrate_set_bitmap_node_mapping(MigrationBlockNodeMappingList > *mapping, > + Error **errp) > +{ > +QDict *in_mapping = qdict_new(); > +QDict *out_mapping = qdict_new(); > + > +for (;

Re: [RFC v2] migration: Add migrate-set-bitmap-node-mapping

2020-05-14 Thread Max Reitz
On 13.05.20 22:09, Vladimir Sementsov-Ogievskiy wrote: > 13.05.2020 17:56, Max Reitz wrote: >> This command allows mapping block node names to aliases for the purpose >> of block dirty bitmap migration. >> >> This way, management tools can use different node names on the source >> and destination

Re: [RFC v2] migration: Add migrate-set-bitmap-node-mapping

2020-05-14 Thread Max Reitz
On 13.05.20 18:11, Eric Blake wrote: > On 5/13/20 9:56 AM, Max Reitz wrote: >> This command allows mapping block node names to aliases for the purpose >> of block dirty bitmap migration. >> >> This way, management tools can use different node names on the source >> and destination and pass the

Re: [RFC v2] migration: Add migrate-set-bitmap-node-mapping

2020-05-13 Thread Vladimir Sementsov-Ogievskiy
13.05.2020 17:56, Max Reitz wrote: This command allows mapping block node names to aliases for the purpose of block dirty bitmap migration. This way, management tools can use different node names on the source and destination and pass the mapping of how bitmaps are to be transferred to qemu (on

Re: [RFC v2] migration: Add migrate-set-bitmap-node-mapping

2020-05-13 Thread Eric Blake
On 5/13/20 9:56 AM, Max Reitz wrote: This command allows mapping block node names to aliases for the purpose of block dirty bitmap migration. This way, management tools can use different node names on the source and destination and pass the mapping of how bitmaps are to be transferred to qemu

[RFC v2] migration: Add migrate-set-bitmap-node-mapping

2020-05-13 Thread Max Reitz
This command allows mapping block node names to aliases for the purpose of block dirty bitmap migration. This way, management tools can use different node names on the source and destination and pass the mapping of how bitmaps are to be transferred to qemu (on the source, the destination, or even