RE: [PATCH 05/46] virtio-crypto-pci: Tidy up virtio_crypto_pci_realize()

2020-06-27 Thread Gonglei (Arei)
> -Original Message- > From: Markus Armbruster [mailto:arm...@redhat.com] > Sent: Thursday, June 25, 2020 12:43 AM > To: qemu-de...@nongnu.org > Cc: pbonz...@redhat.com; berra...@redhat.com; ehabk...@redhat.com; > qemu-block@nongnu.org; peter.mayd...@linaro.org; >

Re: [PATCH 05/46] virtio-crypto-pci: Tidy up virtio_crypto_pci_realize()

2020-06-25 Thread Vladimir Sementsov-Ogievskiy
24.06.2020 19:43, Markus Armbruster wrote: virtio_crypto_pci_realize() continues after realization of its "virtio-crypto-device" fails. Only an object_property_set_link() follows; looks harmless to me. Tidy up anyway: return after failure, just like virtio_rng_pci_realize() does. Cc: "Gonglei

Re: [PATCH 05/46] virtio-crypto-pci: Tidy up virtio_crypto_pci_realize()

2020-06-24 Thread Eric Blake
On 6/24/20 11:43 AM, Markus Armbruster wrote: virtio_crypto_pci_realize() continues after realization of its "virtio-crypto-device" fails. Only an object_property_set_link() follows; looks harmless to me. Tidy up anyway: return after failure, just like virtio_rng_pci_realize() does. Cc: