Re: [Qemu-block] [PATCH] error: Avoid redudant error_propagate() usage

2016-06-09 Thread Eduardo Habkost
On Thu, Jun 09, 2016 at 02:57:08PM -0600, Eric Blake wrote: > On 06/09/2016 02:21 PM, Eduardo Habkost wrote: > > This patch simplifies code that uses a local_err variable just to > > immediately > > use it for an error_propagate() call. > > > > Done using the following Coccinelle patch: > > > >

Re: [Qemu-block] [PATCH] error: Avoid redudant error_propagate() usage

2016-06-09 Thread Eduardo Habkost
On Thu, Jun 09, 2016 at 02:54:51PM -0600, Eric Blake wrote: > On 06/09/2016 02:47 PM, Eduardo Habkost wrote: > > On Thu, Jun 09, 2016 at 05:21:34PM -0300, Eduardo Habkost wrote: > >> This patch simplifies code that uses a local_err variable just to > >> immediately > >> use it for an error_propaga

Re: [Qemu-block] [PATCH] error: Avoid redudant error_propagate() usage

2016-06-09 Thread Eric Blake
On 06/09/2016 02:21 PM, Eduardo Habkost wrote: > This patch simplifies code that uses a local_err variable just to immediately > use it for an error_propagate() call. > > Done using the following Coccinelle patch: > > +++ b/block.c > @@ -353,7 +353,6 @@ out: > int bdrv_create_file(const char *f

Re: [Qemu-block] [PATCH] error: Avoid redudant error_propagate() usage

2016-06-09 Thread Eric Blake
On 06/09/2016 02:47 PM, Eduardo Habkost wrote: > On Thu, Jun 09, 2016 at 05:21:34PM -0300, Eduardo Habkost wrote: >> This patch simplifies code that uses a local_err variable just to immediately >> use it for an error_propagate() call. > > Please ignore this one. I found a better way to tell Cocci

Re: [Qemu-block] [PATCH] error: Avoid redudant error_propagate() usage

2016-06-09 Thread Eduardo Habkost
On Thu, Jun 09, 2016 at 05:21:34PM -0300, Eduardo Habkost wrote: > This patch simplifies code that uses a local_err variable just to immediately > use it for an error_propagate() call. Please ignore this one. I found a better way to tell Coccinelle to do that. Updated Coccinelle patch is below, bu